Skip to content

Commit f355c03

Browse files
scheglovCommit Queue
authored andcommitted
DeCo. Write FieldElement/TopLevelVariableElement.hasImplicitType
Also write `TopLevelVariableElement.isExternal` Bug: #61701 Change-Id: I00799ba5871158abddec2b5a3c9b0436abfce8a7 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/459841 Reviewed-by: Paul Berry <paulberry@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
1 parent 4efc3eb commit f355c03

22 files changed

+831
-828
lines changed

pkg/analyzer/test/src/dart/analysis/driver_test.dart

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -26517,7 +26517,7 @@ final x = a;
2651726517
[future] getLibraryByUri T1
2651826518
library
2651926519
topLevelVariables
26520-
final hasInitializer x
26520+
final hasImplicitType hasInitializer x
2652126521
type: int
2652226522
exportedReferences
2652326523
declared <testLibrary>::@getter::x
@@ -26598,7 +26598,7 @@ final a = 1.2;
2659826598
[future] getLibraryByUri T2
2659926599
library
2660026600
topLevelVariables
26601-
final hasInitializer x
26601+
final hasImplicitType hasInitializer x
2660226602
type: double
2660326603
exportedReferences
2660426604
declared <testLibrary>::@getter::x
@@ -42147,7 +42147,7 @@ final x = foo();
4214742147
[future] getLibraryByUri T1
4214842148
library
4214942149
topLevelVariables
42150-
final hasInitializer x
42150+
final hasImplicitType hasInitializer x
4215142151
type: int
4215242152
''',
4215342153
updatedA: r'''
@@ -42194,7 +42194,7 @@ double foo() {}
4219442194
[future] getLibraryByUri T2
4219542195
library
4219642196
topLevelVariables
42197-
final hasInitializer x
42197+
final hasImplicitType hasInitializer x
4219842198
type: double
4219942199
''',
4220042200
);
@@ -42248,7 +42248,7 @@ final x = foo();
4224842248
[future] getLibraryByUri T1
4224942249
library
4225042250
topLevelVariables
42251-
final hasInitializer x
42251+
final hasImplicitType hasInitializer x
4225242252
type: int
4225342253
''',
4225442254
updatedA: r'''
@@ -42274,7 +42274,7 @@ double bar() {}
4227442274
[future] getLibraryByUri T2
4227542275
library
4227642276
topLevelVariables
42277-
final hasInitializer x
42277+
final hasImplicitType hasInitializer x
4227842278
type: int
4227942279
''',
4228042280
);
@@ -42327,7 +42327,7 @@ final x = a;
4232742327
[future] getLibraryByUri T1
4232842328
library
4232942329
topLevelVariables
42330-
final hasInitializer x
42330+
final hasImplicitType hasInitializer x
4233142331
type: int
4233242332
''',
4233342333
updatedA: r'''
@@ -42376,7 +42376,7 @@ double get a => 1.2;
4237642376
[future] getLibraryByUri T2
4237742377
library
4237842378
topLevelVariables
42379-
final hasInitializer x
42379+
final hasImplicitType hasInitializer x
4238042380
type: double
4238142381
''',
4238242382
);
@@ -42433,7 +42433,7 @@ final x = a;
4243342433
[future] getLibraryByUri T1
4243442434
library
4243542435
topLevelVariables
42436-
final hasInitializer x
42436+
final hasImplicitType hasInitializer x
4243742437
type: int
4243842438
''',
4243942439
updatedA: r'''
@@ -42462,7 +42462,7 @@ double get b => 1.2;
4246242462
[future] getLibraryByUri T2
4246342463
library
4246442464
topLevelVariables
42465-
final hasInitializer x
42465+
final hasImplicitType hasInitializer x
4246642466
type: int
4246742467
''',
4246842468
);
@@ -42537,7 +42537,7 @@ final x = a;
4253742537
[future] getLibraryByUri T1
4253842538
library
4253942539
topLevelVariables
42540-
final hasInitializer x
42540+
final hasImplicitType hasInitializer x
4254142541
type: int
4254242542
''',
4254342543
// Change the initializer, now `double`.
@@ -42614,7 +42614,7 @@ final a = 1.2;
4261442614
[future] getLibraryByUri T2
4261542615
library
4261642616
topLevelVariables
42617-
final hasInitializer x
42617+
final hasImplicitType hasInitializer x
4261842618
type: double
4261942619
''',
4262042620
);
@@ -42667,7 +42667,7 @@ final x = a;
4266742667
[future] getLibraryByUri T1
4266842668
library
4266942669
topLevelVariables
42670-
final hasInitializer x
42670+
final hasImplicitType hasInitializer x
4267142671
type: int
4267242672
''',
4267342673
// Change the initializer, now `double`.
@@ -42718,7 +42718,7 @@ final a = 1.2;
4271842718
[future] getLibraryByUri T2
4271942719
library
4272042720
topLevelVariables
42721-
final hasInitializer x
42721+
final hasImplicitType hasInitializer x
4272242722
type: double
4272342723
''',
4272442724
);
@@ -98997,7 +98997,7 @@ final x = a;
9899798997
[future] getLibraryByUri T1
9899898998
library
9899998999
topLevelVariables
99000-
final hasInitializer x
99000+
final hasImplicitType hasInitializer x
9900199001
type: int
9900299002
''',
9900399003
updatedA: r'''
@@ -99046,7 +99046,7 @@ double get a => 1.2;
9904699046
[future] getLibraryByUri T2
9904799047
library
9904899048
topLevelVariables
99049-
final hasInitializer x
99049+
final hasImplicitType hasInitializer x
9905099050
type: double
9905199051
''',
9905299052
);
@@ -99155,7 +99155,7 @@ final x = a;
9915599155
[future] getLibraryByUri T1
9915699156
library
9915799157
topLevelVariables
99158-
final hasInitializer x
99158+
final hasImplicitType hasInitializer x
9915999159
type: int
9916099160
''',
9916199161
updatedA: r'''
@@ -99187,7 +99187,7 @@ int get b => 0;
9918799187
[future] getLibraryByUri T2
9918899188
library
9918999189
topLevelVariables
99190-
final hasInitializer x
99190+
final hasImplicitType hasInitializer x
9919199191
type: int
9919299192
''',
9919399193
);

pkg/analyzer/test/src/summary/element_text.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -545,6 +545,7 @@ class _Element2Writer extends _AbstractElementWriter {
545545
_sink.writeIf(e.isConst, 'const ');
546546
_sink.writeIf(e.isEnumConstant, 'enumConstant ');
547547
_sink.writeIf(e.isPromotable, 'promotable ');
548+
_sink.writeIf(e.hasImplicitType, 'hasImplicitType ');
548549
_sink.writeIf(e.hasInitializer, 'hasInitializer ');
549550

550551
_writeElementName(e);
@@ -1656,9 +1657,11 @@ class _Element2Writer extends _AbstractElementWriter {
16561657

16571658
_sink.writeIndentedLine(() {
16581659
_sink.writeIf(e.isSynthetic, 'synthetic ');
1660+
_sink.writeIf(e.isExternal, 'external ');
16591661
_sink.writeIf(e.isLate, 'late ');
16601662
_sink.writeIf(e.isFinal, 'final ');
16611663
_sink.writeIf(e.isConst, 'const ');
1664+
_sink.writeIf(e.hasImplicitType, 'hasImplicitType ');
16621665
_sink.writeIf(e.hasInitializer, 'hasInitializer ');
16631666

16641667
_writeElementName(e);

0 commit comments

Comments
 (0)