Fine. Use Reference.elementName, Element.lookupName to fix crash when duplicate declarations.

Bug: #61782 Change-Id: I99ce0e8e0be17678d15b7e1212a0ac04945b80f2 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/456802 Commit-Queue: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Johnni Winther <johnniwinther@google.com>

Author: scheglov

pkg/analyzer/lib/src/dart/analysis/driver.dart

@@ -107,7 +107,7 @@ testFineAfterLibraryAnalyzerHook;
 // TODO(scheglov): Clean up the list of implicitly analyzed files.
 class AnalysisDriver {
  /// The version of data format, should be incremented on every format change.
- static const int DATA_VERSION = 580;
+ static const int DATA_VERSION = 581;
 
  /// The number of exception contexts allowed to write. Once this field is
  /// zero, we stop writing any new exception contexts in this process.

pkg/analyzer/lib/src/fine/library_manifest.dart

@@ -748,12 +748,13 @@ class LibraryManifestBuilder {
  }
 
  var reference = exported.reference;
- var lookupName = reference.isSetter
- ? '${reference.name}='.asLookupName
- : reference.name.asLookupName;
-
  var element = elementFactory.elementOfReference3(reference);
 
+ var lookupName = element.lookupName?.asLookupName;
+ if (lookupName == null) {
+ continue;
+ }
+
  // Skip elements that exist in nowhere.
  var elementLibrary = element.library;
  if (elementLibrary == null) {

pkg/analyzer/lib/src/summary2/library_builder.dart

@@ -132,7 +132,7 @@ class LibraryBuilder {
  var exportedReferences = exportedLibrary.exportedReferences;
  for (var exported in exportedReferences) {
  var reference = exported.reference;
- var name = reference.name;
+ var name = reference.elementName;
  if (reference.isSetter) {
  export.addToExportScope('$name=', exported);
  } else {

pkg/analyzer/test/src/dart/analysis/driver_test.dart

@@ -23435,6 +23435,120 @@ class A2 {}
  );
  }
 
+ test_dependency_export_class_reExport_duplicate() async {
+ var a = newFile('$testPackageLibPath/a.dart', r'''
+class A {}
+class A {}
+''');
+
+ newFile('$testPackageLibPath/test.dart', r'''
+export 'a.dart';
+''');
+
+ configuration.elementTextConfiguration.withExportScope = true;
+ await _runChangeScenario(
+ operation: _FineOperationGetTestLibrary(),
+ expectedInitialEvents: r'''
+[status] working
+[operation] linkLibraryCycle SDK
+[operation] linkLibraryCycle
+ package:test/a.dart
+ hashForRequirements: #H0
+ declaredConflicts
+ A: #M0
+ A=: #M0
+ exportMapId: #M1
+ exportMap
+ A: #M0
+ A=: #M0
+ requirements
+[operation] linkLibraryCycle
+ package:test/test.dart
+ hashForRequirements: #H1
+ exportMapId: #M2
+ exportMap
+ A: #M0
+ reExportMap
+ A: #M0
+ exportedLibraryUris: package:test/a.dart
+ requirements
+ exportRequirements
+ package:test/test.dart
+ exports
+ package:test/a.dart
+ A: #M0
+[status] idle
+[future] getLibraryByUri T1
+ library
+ exportedReferences
+ exported[(0, 0)] package:test/a.dart::@class::A::@def::1
+ exportNamespace
+ A: package:test/a.dart::@class::A::@def::1
+''',
+ updateFiles: () {
+ modifyFile2(a, r'''
+class A {}
+class A {}
+class B {}
+''');
+ return [a];
+ },
+ expectedUpdatedEvents: r'''
+[status] working
+[operation] linkLibraryCycle
+ package:test/a.dart
+ hashForRequirements: #H2
+ declaredConflicts
+ A: #M3
+ A=: #M3
+ declaredClasses
+ B: #M4
+ interface: #M5
+ exportMapId: #M6
+ exportMap
+ A: #M3
+ A=: #M3
+ B: #M4
+ requirements
+[operation] checkLinkedBundleRequirements
+ package:test/test.dart
+ exportIdMismatch
+ fragmentUri: package:test/test.dart
+ exportedUri: package:test/a.dart
+ name: A
+ expectedId: #M0
+ actualId: #M3
+[operation] linkLibraryCycle
+ package:test/test.dart
+ hashForRequirements: #H3
+ exportMapId: #M7
+ exportMap
+ A: #M3
+ B: #M4
+ reExportMap
+ A: #M3
+ B: #M4
+ exportedLibraryUris: package:test/a.dart
+ requirements
+ exportRequirements
+ package:test/test.dart
+ exports
+ package:test/a.dart
+ A: #M3
+ B: #M4
+[status] idle
+[future] getLibraryByUri T2
+ library
+ exportedReferences
+ exported[(0, 0)] package:test/a.dart::@class::A::@def::1
+ exported[(0, 0)] package:test/a.dart::@class::B
+ exportNamespace
+ A: package:test/a.dart::@class::A::@def::1
+ B: package:test/a.dart::@class::B
+''',
+ );
+ }
+
  test_dependency_export_dynamic() async {
  configuration
  ..withGetErrorsEvents = false