[messages] Remove unnecessary if test.

Removes the `if (diagnosticCode is CompileTimeErrorCode)` test in `_ConstantDiagnosticListener.onDiagnostic`. This test was unnecessary, since the enclosed switch statement does nothing in the default case. This is a step toward collapsoing the `DiagnosticCode` class hierarchy and removing classes like `CompileTimeErrorCode` entirely. Change-Id: I6a6a69640d9076f3a6ed8bb976ce6fb122e0413a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/459120 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Paul Berry <paulberry@google.com>

Author: stereotype441

pkg/analyzer/lib/src/lint/constants.dart

@@ -26,45 +26,42 @@ class _ConstantDiagnosticListener extends DiagnosticListener {
  @override
  void onDiagnostic(Diagnostic diagnostic) {
  DiagnosticCode diagnosticCode = diagnostic.diagnosticCode;
- if (diagnosticCode is CompileTimeErrorCode) {
- switch (diagnosticCode) {
- case CompileTimeErrorCode.constConstructorConstantFromDeferredLibrary:
- case CompileTimeErrorCode
- .constConstructorWithFieldInitializedByNonConst:
- case CompileTimeErrorCode.constEvalExtensionMethod:
- case CompileTimeErrorCode.constEvalExtensionTypeMethod:
- case CompileTimeErrorCode.constEvalMethodInvocation:
- case CompileTimeErrorCode.constEvalPropertyAccess:
- case CompileTimeErrorCode.constEvalTypeBool:
- case CompileTimeErrorCode.constEvalTypeBoolInt:
- case CompileTimeErrorCode.constEvalTypeBoolNumString:
- case CompileTimeErrorCode.constEvalTypeInt:
- case CompileTimeErrorCode.constEvalTypeNum:
- case CompileTimeErrorCode.constEvalTypeNumString:
- case CompileTimeErrorCode.constEvalTypeString:
- case CompileTimeErrorCode.constEvalThrowsException:
- case CompileTimeErrorCode.constEvalThrowsIdbze:
- case CompileTimeErrorCode.constEvalForElement:
- case CompileTimeErrorCode.constMapKeyNotPrimitiveEquality:
- case CompileTimeErrorCode.constSetElementNotPrimitiveEquality:
- case CompileTimeErrorCode.constTypeParameter:
- case CompileTimeErrorCode.constWithNonConst:
- case CompileTimeErrorCode.constWithNonConstantArgument:
- case CompileTimeErrorCode.constWithTypeParameters:
- case CompileTimeErrorCode.constWithTypeParametersConstructorTearoff:
- case CompileTimeErrorCode.invalidConstant:
- case CompileTimeErrorCode.missingConstInListLiteral:
- case CompileTimeErrorCode.missingConstInMapLiteral:
- case CompileTimeErrorCode.missingConstInSetLiteral:
- case CompileTimeErrorCode.nonBoolCondition:
- case CompileTimeErrorCode.nonConstantListElement:
- case CompileTimeErrorCode.nonConstantMapElement:
- case CompileTimeErrorCode.nonConstantMapKey:
- case CompileTimeErrorCode.nonConstantMapValue:
- case CompileTimeErrorCode.nonConstantRecordField:
- case CompileTimeErrorCode.nonConstantSetElement:
- hasConstError = true;
- }
+ switch (diagnosticCode) {
+ case CompileTimeErrorCode.constConstructorConstantFromDeferredLibrary:
+ case CompileTimeErrorCode.constConstructorWithFieldInitializedByNonConst:
+ case CompileTimeErrorCode.constEvalExtensionMethod:
+ case CompileTimeErrorCode.constEvalExtensionTypeMethod:
+ case CompileTimeErrorCode.constEvalMethodInvocation:
+ case CompileTimeErrorCode.constEvalPropertyAccess:
+ case CompileTimeErrorCode.constEvalTypeBool:
+ case CompileTimeErrorCode.constEvalTypeBoolInt:
+ case CompileTimeErrorCode.constEvalTypeBoolNumString:
+ case CompileTimeErrorCode.constEvalTypeInt:
+ case CompileTimeErrorCode.constEvalTypeNum:
+ case CompileTimeErrorCode.constEvalTypeNumString:
+ case CompileTimeErrorCode.constEvalTypeString:
+ case CompileTimeErrorCode.constEvalThrowsException:
+ case CompileTimeErrorCode.constEvalThrowsIdbze:
+ case CompileTimeErrorCode.constEvalForElement:
+ case CompileTimeErrorCode.constMapKeyNotPrimitiveEquality:
+ case CompileTimeErrorCode.constSetElementNotPrimitiveEquality:
+ case CompileTimeErrorCode.constTypeParameter:
+ case CompileTimeErrorCode.constWithNonConst:
+ case CompileTimeErrorCode.constWithNonConstantArgument:
+ case CompileTimeErrorCode.constWithTypeParameters:
+ case CompileTimeErrorCode.constWithTypeParametersConstructorTearoff:
+ case CompileTimeErrorCode.invalidConstant:
+ case CompileTimeErrorCode.missingConstInListLiteral:
+ case CompileTimeErrorCode.missingConstInMapLiteral:
+ case CompileTimeErrorCode.missingConstInSetLiteral:
+ case CompileTimeErrorCode.nonBoolCondition:
+ case CompileTimeErrorCode.nonConstantListElement:
+ case CompileTimeErrorCode.nonConstantMapElement:
+ case CompileTimeErrorCode.nonConstantMapKey:
+ case CompileTimeErrorCode.nonConstantMapValue:
+ case CompileTimeErrorCode.nonConstantRecordField:
+ case CompileTimeErrorCode.nonConstantSetElement:
+ hasConstError = true;
  }
  }
 }