Breaking changes for analyzer version 9.0.0

Change-Id: I4d1b611edcf5340543b5cabf93b88a103408920b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/444924 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Reviewed-by: Johnni Winther <johnniwinther@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>

Author: scheglov

pkg/_fe_analyzer_shared/lib/src/base/errors.dart

@@ -71,10 +71,6 @@ class Diagnostic {
  /// being reported. The list will be empty if there are no such messages.
  final List<DiagnosticMessage> contextMessages;
 
- /// Data associated with this diagnostic, specific for [diagnosticCode].
- @Deprecated('Use an expando instead')
- final Object? data;
-
  /// A description of how to fix the problem, or `null` if there is no such
  /// description.
  final String? correctionMessage;
@@ -89,15 +85,11 @@ class Diagnostic {
  required this.source,
  required int offset,
  required int length,
- DiagnosticCode? diagnosticCode,
- @Deprecated("Pass a value for 'diagnosticCode' instead")
- DiagnosticCode? errorCode,
+ required this.diagnosticCode,
  required String message,
  this.correctionMessage,
  this.contextMessages = const [],
- @Deprecated('Use an expando instead') this.data,
- }) : diagnosticCode = _useNonNullCodeBetween(diagnosticCode, errorCode),
- problemMessage = new DiagnosticMessageImpl(
+ }) : problemMessage = new DiagnosticMessageImpl(
  filePath: source.fullName,
  length: length,
  message: message,
@@ -109,31 +101,27 @@ class Diagnostic {
  ///
  /// The diagnostic is associated with the given [source] and is located at the
  /// given [offset] with the given [length]. The diagnostic will have the given
- /// [errorCode] and the list of [arguments] will be used to complete the
+ /// [diagnosticCode] and the list of [arguments] will be used to complete the
  /// message and correction. If any [contextMessages] are provided, they will
  /// be recorded with the diagnostic.
  factory Diagnostic.tmp({
  required Source source,
  required int offset,
  required int length,
- DiagnosticCode? diagnosticCode,
- @Deprecated("Pass a value for 'diagnosticCode' instead")
- DiagnosticCode? errorCode,
+ required DiagnosticCode diagnosticCode,
  List<Object?> arguments = const [],
  List<DiagnosticMessage> contextMessages = const [],
- @Deprecated('Use an expando instead') Object? data,
  }) {
- DiagnosticCode code = _useNonNullCodeBetween(diagnosticCode, errorCode);
  assert(
- arguments.length == code.numParameters,
- 'Message $code requires ${code.numParameters} '
- 'argument${code.numParameters == 1 ? '' : 's'}, but '
+ arguments.length == diagnosticCode.numParameters,
+ 'Message $diagnosticCode requires ${diagnosticCode.numParameters} '
+ 'argument${diagnosticCode.numParameters == 1 ? '' : 's'}, but '
  '${arguments.length} '
  'argument${arguments.length == 1 ? ' was' : 's were'} '
  'provided',
  );
- String message = formatList(code.problemMessage, arguments);
- String? correctionTemplate = code.correctionMessage;
+ String message = formatList(diagnosticCode.problemMessage, arguments);
+ String? correctionTemplate = diagnosticCode.correctionMessage;
  String? correctionMessage;
  if (correctionTemplate != null) {
  correctionMessage = formatList(correctionTemplate, arguments);
@@ -143,12 +131,10 @@ class Diagnostic {
  source: source,
  offset: offset,
  length: length,
- diagnosticCode: code,
+ diagnosticCode: diagnosticCode,
  message: message,
  correctionMessage: correctionMessage,
  contextMessages: contextMessages,
- // ignore: deprecated_member_use_from_same_package
- data: data,
  );
  }
 
@@ -233,19 +219,6 @@ class Diagnostic {
  buffer.write(message);
  return buffer.toString();
  }
-
- /// The non-`null` [DiagnosticCode] value between the two parameters.
- static DiagnosticCode _useNonNullCodeBetween(
- DiagnosticCode? diagnosticCode,
- DiagnosticCode? errorCode,
- ) {
- if ((diagnosticCode == null) == (errorCode == null)) {
- throw new ArgumentError(
- "Exactly one of 'diagnosticCode' and 'errorCode' may be passed",
- );
- }
- return diagnosticCode ?? errorCode!;
- }
 }
 
 /// Private subtype of [DiagnosticCode] that supports runtime checking of

pkg/analysis_server/test/protocol_server_test.dart

@@ -363,9 +363,6 @@ class MockDiagnostic implements engine.Diagnostic {
  @override
  String? get correctionMessage => _correctionMessage;
 
- @override
- Object? get data => throw UnimplementedError();
-
  @override
  engine.DiagnosticCode get diagnosticCode => _diagnosticCode!;
 

pkg/analysis_server_plugin/pubspec.yaml

@@ -1,6 +1,6 @@
 name: analysis_server_plugin
 description: A framework and support code for building plugins for the analysis server.
-version: 0.3.3
+version: 0.3.4-dev
 repository: https://github.com/dart-lang/sdk/tree/main/pkg/analysis_server_plugin
 
 environment:
@@ -11,8 +11,8 @@ resolution: workspace
 dependencies:
  # See the release policy for managing this dependency at
  # pkg/analyzer/doc/implementation/releasing.md.
- analyzer: 8.4.0
- analyzer_plugin: 0.13.10
+ analyzer: ^9.0.0-0
+ analyzer_plugin: 0.13.11-dev
  meta: ^1.16.0
  yaml: ^3.1.0
  yaml_edit: ^2.2.0

pkg/analyzer/CHANGELOG.md

@@ -1,3 +1,20 @@
+## 9.0.0-dev
+* Remove deprecated field `Diagnostic.data`.
+* In the method `DiagnosticReporter.atOffset` and the constructors
+ `Diagnostic.tmp` and `Diagnostic.forValues`, remove the deprecated named
+ parameter `errorCode`, and make the named parameter `diagnosticCode`
+ non-nullable and required.
+* Remove deprecated `DiagnosticReporter.atOffset` named parameter, `errorCode`.
+* Remove deprecated `BooleanErrorListener`.
+* Remove deprecated `RecordingErrorListener`.
+* Remove deprecated `AnalysisErrorListener.NULL_LISTENER`.
+* Remove deprecated `AstNodeExtension`.
+* Remove deprecated `NullShortableExpression`.
+* Remove deprecated getters and methods from AST and element model.
+* Remove deprecated `PartDirective.configurations`.
+* Remove deprecated `TypeDefiningElement`.
+* Remove deprecated `TypeAliasElement.aliasedElement`.
+
 ## 8.4.0
 * Add the `experimental_member_use` warning, which warns about any reference to
  a declaration annotated with `@experimental`.