Skip to content
This repository was archived by the owner on Oct 2, 2019. It is now read-only.

Commit 7f073db

Browse files
committed
rename endpoints to paths, use self_url to consgruct endpoints
1 parent d1c0e5b commit 7f073db

File tree

5 files changed

+28
-25
lines changed

5 files changed

+28
-25
lines changed

docker-compose.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,4 @@ services:
1212
- 3001:3001
1313
environment:
1414
- SHELL=/bin/sh
15-
- SELF_URL=http://localhost:3001
15+

src/app.ts

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -38,13 +38,15 @@ const graphqlMiddleware = graphqlKoa({
3838
},
3939
});
4040

41-
router.post(`/${process.env.GRAPHQL_ENDPOINT}*`, koaBodyparser(), graphqlMiddleware);
42-
router.get(`/${process.env.GRAPHQL_ENDPOINT}*`, graphqlMiddleware);
41+
router.post(`/${process.env.GRAPHQL_PATH}*`, koaBodyparser(), graphqlMiddleware);
42+
router.get(`/${process.env.GRAPHQL_PATH}*`, graphqlMiddleware);
43+
44+
const GRAPHQL_ENDPOINT = `${process.env.SELF_URL}/${process.env.GRAPHQL_PATH}`;
4345

4446
// GraphQL Voyager?
4547
if (process.env.VOYAGER) {
46-
router.all(`/${process.env.VOYAGER_ENDPOINT}`, koaMiddleware({
47-
endpointUrl: `/${process.env.GRAPHQL_ENDPOINT}`,
48+
router.all(`/${process.env.VOYAGER_PATH}`, koaMiddleware({
49+
endpointUrl: GRAPHQL_ENDPOINT,
4850
displayOptions: {
4951
sortByAlphabet: true,
5052
},
@@ -53,21 +55,22 @@ if (process.env.VOYAGER) {
5355

5456
// GraphiQL?
5557
if (process.env.GRAPHIQL) {
56-
router.get(`/${process.env.GRAPHIQL_ENDPOINT}`, graphiqlKoa({ endpointURL: `/${process.env.GRAPHQL_ENDPOINT}` }));
58+
router.get(
59+
`/${process.env.GRAPHIQL_PATH}`,
60+
graphiqlKoa({ endpointURL: GRAPHQL_ENDPOINT }),
61+
);
5762
}
5863

5964
// GraphQL Playground?
6065
if (process.env.PLAYGROUND) {
6166
router.all(
62-
`/${process.env.PLAYGROUND_ENDPOINT}`,
63-
koaPlayground({
64-
endpoint: `/${process.env.GRAPHQL_ENDPOINT}`,
65-
}),
67+
`/${process.env.PLAYGROUND_PATH}`,
68+
koaPlayground({ endpoint: GRAPHQL_ENDPOINT }),
6669
);
6770
}
6871

6972
// Koa Heartbeat
70-
app.use(koaHeartbeat({ path: `/${process.env.LIVENESS_ENDPOINT}`, body: 'ok' }));
73+
app.use(koaHeartbeat({ path: `/${process.env.LIVENESS_PATH}`, body: 'ok' }));
7174

7275
app.use(router.routes());
7376
app.use(router.allowedMethods());

src/entrypoint.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,11 @@ import fs from 'fs';
33
import { pickBy, identity, isEmpty } from 'lodash';
44

55
const endpointsConfig = {
6-
graphql: `${process.env.SELF_URL}/${process.env.GRAPHQL_ENDPOINT}`,
7-
liveness: `${process.env.SELF_URL}/${process.env.LIVENESS_ENDPOINT}`,
8-
graphiql: process.env.GRAPHIQL && `${process.env.SELF_URL}/${process.env.GRAPHIQL_ENDPOINT}`,
9-
playground: process.env.PLAYGROUND && `${process.env.SELF_URL}/${process.env.PLAYGROUND_ENDPOINT}`,
10-
voyager: process.env.VOYAGER && `${process.env.SELF_URL}/${process.env.VOYAGER_ENDPOINT}`,
6+
graphql: `${process.env.SELF_URL}/${process.env.GRAPHQL_PATH}`,
7+
liveness: `${process.env.SELF_URL}/${process.env.LIVENESS_PATH}`,
8+
graphiql: process.env.GRAPHIQL && `${process.env.SELF_URL}/${process.env.GRAPHIQL_PATH}`,
9+
playground: process.env.PLAYGROUND && `${process.env.SELF_URL}/${process.env.PLAYGROUND_PATH}`,
10+
voyager: process.env.VOYAGER && `${process.env.SELF_URL}/${process.env.VOYAGER_PATH}`,
1111
};
1212

1313
const packageJsonPath = path.resolve('package.json');

src/env.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,20 +4,20 @@ const { url, bool, str, port } = envalid;
44

55
const env = envalid.cleanEnv(process.env, {
66
PORT: port({ default: 3001 }),
7-
SELF_URL: str({ default: '' }),
7+
SELF_URL: str({ devDefault: 'http://localhost:3001' }),
88
NODE_ENV: str({ devDefault: 'development' }),
99
JOKE_SERVICE_URL: url({ default: 'https://api.icndb.com' }),
10-
GRAPHQL_ENDPOINT: str({ default: 'graphql' }),
10+
GRAPHQL_PATH: str({ default: 'graphql' }),
1111
GRAPHQL_TRACING: bool({ default: true }),
1212
GRAPHIQL: bool({ default: true }),
13-
GRAPHIQL_ENDPOINT: str({ default: 'graphiql' }),
13+
GRAPHIQL_PATH: str({ default: 'graphiql' }),
1414
VOYAGER: bool({ default: true }),
15-
VOYAGER_ENDPOINT: str({ default: 'voyager' }),
15+
VOYAGER_PATH: str({ default: 'voyager' }),
1616
PLAYGROUND: bool({ default: true }),
17-
PLAYGROUND_ENDPOINT: str({ default: 'playground' }),
17+
PLAYGROUND_PATH: str({ default: 'playground' }),
1818
CORS: bool({ devDefault: true, default: false }),
1919
LOG_LEVEL: str({ default: 'info' }),
20-
LIVENESS_ENDPOINT: str({ default: 'healthz' }),
20+
LIVENESS_PATH: str({ default: 'healthz' }),
2121
});
2222

2323
export default env;

src/server.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ app.listen(port, () => {
1212
if (process.env.GRAPHIQL) {
1313
console.log(`The GraphiQL App is running at:`);
1414
console.log();
15-
console.log(` ${chalk.cyan(`http://localhost:${port}/${process.env.GRAPHIQL_ENDPOINT}`)}`);
15+
console.log(` ${chalk.cyan(`http://localhost:${port}/${process.env.GRAPHIQL_PATH }`)}`);
1616
} else {
1717
console.log(`The Koa App is running at:`);
1818
console.log();
@@ -24,15 +24,15 @@ app.listen(port, () => {
2424
}
2525
console.log(`The GraphQL Voyager App is running at:`);
2626
console.log();
27-
console.log(` ${chalk.cyan(`http://localhost:${port}/${process.env.VOYAGER_ENDPOINT}`)}`);
27+
console.log(` ${chalk.cyan(`http://localhost:${port}/${process.env.VOYAGER_PATH}`)}`);
2828
}
2929
if (process.env.PLAYGROUND) {
3030
if (process.env.GRAPHIQL || process.env.VOYAGER) {
3131
console.log();
3232
}
3333
console.log(`The GraphQL Plaground App is running at:`);
3434
console.log();
35-
console.log(` ${chalk.cyan(`http://localhost:${port}/${process.env.PLAYGROUND_ENDPOINT}`)}`);
35+
console.log(` ${chalk.cyan(`http://localhost:${port}/${process.env.PLAYGROUND_PATH}`)}`);
3636
}
3737
} else {
3838
console.log(`The Koa App is running`);

0 commit comments

Comments
 (0)