fix: Flush DeleteRecord messages when batch writer is flushed #2154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
erezrokah approved these changes May 19, 2025
murarustefaan approved these changes May 19, 2025
przste-go approved these changes May 19, 2025
kodiakhq bot pushed a commit that referenced this pull request May 19, 2025
🤖 I have created a release *beep* *boop* --- ## [4.80.2](v4.80.1...v4.80.2) (2025-05-19) ### Bug Fixes * Change logic for batch writing to write when batch size is reached, not exceeded ([#2153](#2153)) ([58c8a1e](58c8a1e)) * Flush DeleteRecord messages when batch writer is flushed ([#2154](#2154)) ([791c865](791c865)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The current logic for
BatchWriterdoes not flushDeleteRecordmessages when the writer is flushed. This PR adds that flushing.I'm also wondering whether we should add a call to
flushDeleteRecordTablesin https://github.com/cloudquery/plugin-sdk/blob/main/writers/batchwriter/batchwriter.go#L307-L315. WDYT?