add missing type for send_email's experimental_remote field

[dario-piotrowicz]

I noticed that we're missing the experimental_remote field in the send_email wrangler config:

Although as you can see from e2e tests this is an expected field:

workers-sdk/packages/wrangler/e2e/remote-binding/wrangler-remote-resources.test.ts

Lines 395 to 400 in dceb550

	send_email: [
	{
	name: "EMAIL",
	experimental_remote: true,
	},
	],

---

• Tests
  • Tests included
  • Tests not necessary because: the functionality using the field is already tested and we don't have type-specific tests
• Public documentation
  • Cloudflare docs PR(s):
  • Documentation not necessary because: already documented
• Wrangler V3 Backport
  • Wrangler PR:
  • Not necessary because: not a wrangler v3 feature

[changeset-bot]

🦋 Changeset detected

Latest commit: e7fade7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
wrangler	Patch
@cloudflare/vite-plugin	Patch
@cloudflare/vitest-pool-workers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

These changes have been automatically backported to Wrangler v3 🎉 You can view the automatically updated PR at v3-maintenance...v3-backport-10571. Please check that PR for correctness, and make sure it's merged after this one. Thank you for helping us keep Wrangler v3 supported!

[pkg-pr-new]

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10571 

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10571 

miniflare

npm i https://pkg.pr.new/miniflare@10571 

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10571 

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10571 

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10571 

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10571 

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10571 

wrangler

npm i https://pkg.pr.new/wrangler@10571 

commit: e7fade7

[edmundhung]

I am curious why this doesn't get caught by the type checker. Didn't we use this config to infer the miniflare setup?

[dario-piotrowicz]

We check the remote field here:

But as you can see the type is just object so there isn't a strong type checking here

After that we do filter the bindings that need to be remote, but we check if "experimental_remote" in binding:

Which again would not fail if experimental_remote wasn't part of the type

So we simply miss the fact that the field wasn't defined in the type 🤔