Skip to content

Cloudfront - add expire time in signed cookie. #2862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 1, 2024
Merged

Cloudfront - add expire time in signed cookie. #2862

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8741ad5
Add expire time
deepenpatel19 Oct 30, 2024
ff53d4e
Remove naming.
deepenpatel19 Oct 30, 2024
e6aaa01
Changed variable type.
deepenpatel19 Oct 31, 2024
a73b2c2
expire -> expires, changelog
lucix-aws Nov 1, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changelog/457746bef3eb4ef08b5b25548f5cf5d2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"id": "457746be-f3eb-4ef0-8b5b-25548f5cf5d2",
"type": "feature",
"description": "Add Expires field to CookieOptions.",
"modules": [
"feature/cloudfront/sign"
]
}
4 changes: 4 additions & 0 deletions feature/cloudfront/sign/sign_cookie.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ type CookieOptions struct {
Domain string
Secure bool
SameSite http.SameSite
Expires time.Time
}

// apply will integration the options provided into the base cookie options
Expand Down Expand Up @@ -219,16 +220,19 @@ func createCookies(p *Policy, keyID string, privKey *rsa.PrivateKey, opt CookieO
Name: CookiePolicyName,
Value: string(b64Policy),
HttpOnly: true,
Expires: opt.Expires,
}
cSignature := &http.Cookie{
Name: CookieSignatureName,
Value: string(b64Sig),
HttpOnly: true,
Expires: opt.Expires,
}
cKey := &http.Cookie{
Name: CookieKeyIDName,
Value: keyID,
HttpOnly: true,
Expires: opt.Expires,
}

cookies := []*http.Cookie{cPolicy, cSignature, cKey}
Expand Down
Loading