Add isSuccess argument to connect and source (#3294)

Author: andrewmcgivery

.changeset/three-actors-camp.md

@@ -0,0 +1,6 @@
+---
+"@apollo/composition": minor
+"@apollo/federation-internals": minor
+---
+
+Added isSuccess argument to @connect and @source

composition-js/src/__tests__/connectors.test.ts

@@ -561,6 +561,7 @@ describe("connect spec and join__directive", () => {
  queryParams: ""
  }
  errors: { message: "" extensions: "" }
+ isSuccess: ""
  )
 
  type Query {
@@ -579,6 +580,7 @@ describe("connect spec and join__directive", () => {
  }
  batch: { maxSize: 5 }
  errors: { message: "" extensions: "" }
+ isSuccess: ""
  selection: ""
  ) {
  id: ID!
@@ -624,7 +626,7 @@ describe("connect spec and join__directive", () => {
  @join__directive(graphs: [WITH_CONNECTORS_V0_1_], name: \\"link\\", args: {url: \\"https://specs.apollo.dev/connect/v0.1\\", import: [\\"@connect\\", \\"@source\\"]})
  @join__directive(graphs: [WITH_CONNECTORS_V0_3_], name: \\"link\\", args: {url: \\"https://specs.apollo.dev/connect/v0.3\\", import: [\\"@connect\\", \\"@source\\"]})
  @join__directive(graphs: [WITH_CONNECTORS_V0_1_], name: \\"source\\", args: {name: \\"v1\\", http: {baseURL: \\"http://v1\\"}})
- @join__directive(graphs: [WITH_CONNECTORS_V0_3_], name: \\"source\\", args: {name: \\"v1\\", http: {baseURL: \\"http://v1\\", path: \\"\\", queryParams: \\"\\"}, errors: {message: \\"\\", extensions: \\"\\"}})
+ @join__directive(graphs: [WITH_CONNECTORS_V0_3_], name: \\"source\\", args: {name: \\"v1\\", http: {baseURL: \\"http://v1\\", path: \\"\\", queryParams: \\"\\"}, errors: {message: \\"\\", extensions: \\"\\"}, isSuccess: \\"\\"})
  {
  query: Query
  }
@@ -694,7 +696,7 @@ describe("connect spec and join__directive", () => {
 
  type Resource
  @join__type(graph: WITH_CONNECTORS_V0_3_, key: \\"id\\")
- @join__directive(graphs: [WITH_CONNECTORS_V0_3_], name: \\"connect\\", args: {id: \\"conn_id\\", source: \\"v1\\", http: {GET: \\"/resources\\", path: \\"\\", queryParams: \\"\\"}, batch: {maxSize: 5}, errors: {message: \\"\\", extensions: \\"\\"}, selection: \\"\\"})
+ @join__directive(graphs: [WITH_CONNECTORS_V0_3_], name: \\"connect\\", args: {id: \\"conn_id\\", source: \\"v1\\", http: {GET: \\"/resources\\", path: \\"\\", queryParams: \\"\\"}, batch: {maxSize: 5}, errors: {message: \\"\\", extensions: \\"\\"}, isSuccess: \\"\\", selection: \\"\\"})
  {
  id: ID!
  name: String!

internals-js/src/specs/connectSpec.ts

@@ -86,6 +86,7 @@ export class ConnectSpecDefinition extends FeatureDefinition {
  selection: JSONSelection!
  entity: Boolean = false
  errors: ConnectorErrors
+ isSuccess: JSONSelection
  ) repeatable on FIELD_DEFINITION
  | OBJECT # added in v0.2, validation enforced in rust
  */
@@ -164,12 +165,14 @@ export class ConnectSpecDefinition extends FeatureDefinition {
 
  connect.addArgument('selection', new NonNullType(JSONSelection));
  connect.addArgument('entity', schema.booleanType(), false);
+ connect.addArgument('isSuccess', JSONSelection);
 
  /*
  directive @source(
  name: String!
  http: ConnectHTTP
  errors: ConnectorErrors
+ isSuccess: JSONSelection
  ) repeatable on SCHEMA
  */
  const source = this.addDirective(schema, SOURCE).addLocations(
@@ -201,6 +204,7 @@ export class ConnectSpecDefinition extends FeatureDefinition {
 
  source.addArgument('http', new NonNullType(SourceHTTP));
  source.addArgument('errors', ConnectorErrors);
+ source.addArgument('isSuccess', JSONSelection);
 
  return [];
  }