Make the legacyMode consistent (Filter out all of the module-info.java files in legacy mode, do not use --source-path in legacy mode) #1217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
fridrich commented Jul 12, 2025
fridrich commented - Filter out all of the module-info.java files in legacy mode
- Do not use --source-path in legacy mode as not to suck any of those module-info.java files back
- Generate the javadoc from list of files and not list of packages, which is not working if --source-path is not specified
* Filter out all of the module-info.java files in legacy mode * Do not use --source-path in legacy mode as not to suck any of those module-info.java files back * Generate the javadoc from list of files and not list of packages, which is not working if --source-path is not specified
| Any comments on this one? |
| looks good but I need to test on large projects such Jetty mixing jpms and not jpms for aggregated javadoc. |
olamy changed the title 
JackPGreen added a commit to JackPGreen/maven-javadoc-plugin that referenced this pull request Aug 18, 2025
_Partially_ reverts change in apache#1217, specifically: > Do not use --source-path in legacy mode as not to suck any of those module-info.java files back This is required to ensure correct package resolution on projects that mix modular & non-module Java code.
This was referenced Aug 18, 2025
akurtakov added a commit to akurtakov/eclipse.platform.releng.aggregator that referenced this pull request Aug 27, 2025
Due to apache/maven-javadoc-plugin#1217 legacy mode is no longer compatible with how sourcepath is defined.
akurtakov added a commit to eclipse-platform/eclipse.platform.releng.aggregator that referenced this pull request Aug 27, 2025
Due to apache/maven-javadoc-plugin#1217 legacy mode is no longer compatible with how sourcepath is defined.
akurtakov added a commit to eclipse-platform/eclipse.platform.releng.aggregator that referenced this pull request Sep 1, 2025
Due to apache/maven-javadoc-plugin#1217 legacy mode is no longer compatible with how sourcepath is defined.
olamy pushed a commit that referenced this pull request Sep 4, 2025
* Fix `package {...} does not exist` in `legacyMode` _Partially_ reverts change in #1217, specifically: > Do not use --source-path in legacy mode as not to suck any of those module-info.java files back This is required to ensure correct package resolution on projects that mix modular & non-module Java code. * Add unit test * Copy additional properties from `javadoc-fix-version` HannesWell pushed a commit to eclipse-platform/eclipse.platform.releng.aggregator that referenced this pull request Sep 10, 2025
Due to apache/maven-javadoc-plugin#1217 legacy mode is no longer compatible with how sourcepath is defined.
Merged
HannesWell pushed a commit to eclipse-platform/eclipse.platform.releng.aggregator that referenced this pull request Sep 11, 2025
Due to apache/maven-javadoc-plugin#1217 legacy mode is no longer compatible with how sourcepath is defined.
HannesWell pushed a commit to eclipse-platform/eclipse.platform.releng.aggregator that referenced this pull request Sep 11, 2025
Due to apache/maven-javadoc-plugin#1217 legacy mode is no longer compatible with how sourcepath is defined.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.