Be consistent about data encoding when copying files #1215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
olamy reviewed Jul 14, 2025
src/main/java/org/apache/maven/plugins/javadoc/StaleHelper.java Outdated Show resolved Hide resolved
olamy reviewed Jul 14, 2025
src/main/java/org/apache/maven/plugins/javadoc/StaleHelper.java Outdated Show resolved Hide resolved
olamy changed the title 
Member
| Thanks for your contribution |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The file-name encoding should be consistent through the StaleHelper. If one runs the build in a non-english environment, where UTF-8 is not a default encoding, this can result in error while writing the javadoc. This commit fixes it.