This repository was archived by the owner on May 15, 2020. It is now read-only.
Remove turtlebot3 packages from .rosinstall #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| I will additionally do manual testing on RoboMaker simulation. |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description of changes:
In the same vein as aws-robotics/aws-robomaker-sample-application-cloudwatch#67 and amazon-archives/aws-robomaker-sample-application-persondetection#66, this removes
turtlebot3packages from the.rosinstallfile, so that these packages are no longer obtained by source code throughrosws update, but rather directly by binary throughrosdep install, which should be the preferred method.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.