Skip to content

Commit 6a55252

Browse files
committed
[Ruby 1.9.3] Upgrade to work w/ Ruby 1.9.3
* Use mysql2 v0.3.10 gem - Fixes issues with Lion/Ruby 1.9.3 bugs. * Setup the test database automatically each time `rake test` is run. * Fix issue with where temp files were written out as absolute paths. * Write todo plan for 3.4 release.
1 parent c0a9961 commit 6a55252

File tree

5 files changed

+25
-9
lines changed

5 files changed

+25
-9
lines changed

Gemfile.lock

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ GEM
8989
mocha (0.9.8)
9090
rake
9191
multi_json (1.0.3)
92-
mysql2 (0.3.7)
92+
mysql2 (0.3.10)
9393
nokogiri (1.5.0)
9494
polyglot (0.3.2)
9595
rack (1.3.3)
@@ -128,7 +128,7 @@ GEM
128128
sprockets (2.0.0)
129129
hike (~> 1.2)
130130
rack (~> 1.0)
131-
tilt (!= 1.3.0, ~> 1.1)
131+
tilt (~> 1.1, != 1.3.0)
132132
sqlite3 (1.3.4)
133133
sqlite3-ruby (1.3.3)
134134
sqlite3 (>= 1.3.3)

Rakefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ Cucumber::Rake::Task.new(:features) do |t|
5050
end
5151

5252
desc 'Runs all the tests'
53-
task :test do
53+
task :test => 'app:test:prepare' do
5454
tests_to_run = ENV['TEST'] ? ["test:single"] : %w(test:units test:functionals test:integration features)
5555
errors = tests_to_run.collect do |task|
5656
begin

doc/release_notes.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
v3.4.0
22
======
33

4+
Recommend using Ruby 1.9.3 with this release.
5+
46
Add the ability to add BrowserCMS to Rails projects.
57
* Add bcms install method that will add browsercms to an existing Rails project.
68
* Most core files in the CMS are namespaced under Cms:: . This should reduce the chance of conflicting classes (i.e. what was User is now Cms::User)

features/support/debugging.rb

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33

44
module LaunchBrokenTests
55
LAUNCH = false
6+
67
def launch_broken_tests
78
LAUNCH
89
end
@@ -22,10 +23,14 @@ def launch_broken_tests
2223
end
2324

2425

25-
require File.expand_path(File.join(__FILE__, "..", "..", "..","test", "mock_file"))
26+
require File.expand_path(File.join(__FILE__, "..", "..", "..", "test", "mock_file"))
2627
module FileOperations
2728

28-
def create_file(file_name, text="Test Content")
29+
# Creates an 'uploaded' file block at a given relative path
30+
# @param [String] relative_file_path A relative file path (i.e. /test.txt) for the uploaded block.
31+
def create_file(relative_file_path, text="Test Content")
32+
# We are creating a temp file with no path, so strip leading slash
33+
file_name = relative_file_path.gsub(/^\//, "")
2934
tempfile = Tempfile.new file_name do |f|
3035
f << text
3136
end

todo_list.markdown

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,22 @@
11
Working on bcms 3.4
22

3+
# Short Term
4+
5+
* Get 3.4 ready for release
6+
* Test upgrading from Rails 3.1 project
7+
* Use new migration behavior for engines
8+
* Differ `bundle install` from happening until Gemfile is updated to include bcms
9+
310
# Needs
411

512
* Email a page portlet doesn't work (throws error when you create one) - Add scenarios
613
* Tag Cloud portlet doesn't work (throws error when you create one) - Add scenarios
7-
* Differ `bundle install` from happening until Gemfile is updated to include bcms
8-
* Improve Performance - Sitemap and serving pages is particularly slow
9-
** Use Ancestry gem - It handles automatically turning models into tree via a single column. Would be very very performant in comparison to current behavior.
1014
* Update a few modules (like bcms_news) to test module generation
1115
* Test this on a production environment prior to releasing (things like assets and/or config options might be wonky)
1216
* Rework a few modules to work with Rails 3.1
1317
* Review the README for accuracy in light of engines and asset pipeline
1418

15-
# Wants (Taking advantage of 3.1)
19+
# Wants (Taking advantage of Rails 3.1)
1620

1721
* Add Block.publish and publish! for easier coding. (or just make default for blocks to be published via code and not via UI)
1822
* Verify that instances of Acts::As::ContentPage in projects can correctly load CMS templates
@@ -38,6 +42,11 @@ Working on bcms 3.4
3842
* Move 'datepicker' initialization into application.js
3943
* Upgrade jquery.selectbox-0.5 to jquery.sb.js (https://github.com/revsystems/jQuery-SelectBox). This will likely improve the usability of the selectbox.
4044

45+
# 3.5 Planned Features
46+
47+
* Improve Performance - Sitemap and serving pages is particularly slow
48+
** Use Ancestry gem - It handles automatically turning models into tree via a single column. Would be very very performant in comparison to current behavior.
49+
4150
## New Features
4251

4352
* Make templating better through the UI

0 commit comments

Comments
 (0)