Skip to content

Conversation

@mayeut
Copy link
Contributor

@mayeut mayeut commented Mar 5, 2022

Description:
Create missing pypyX.Y symlinks:
pypyX.Y.exe executables are missing from PyPy archives on Windows before v7.3.9 (X.Y < 3.9)
pypy2.7 symlinks are also missing from macOS/Linux PyPy archives before v7.3.9

Related issue:
relates to #346

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.
@mayeut
Copy link
Contributor Author

mayeut commented Mar 5, 2022

Before the PR, tests are failing for Windows only (3.Y tests there) when trying to use pypyX.Y: https://github.com/mayeut/packaging/actions/runs/1937384250

After the PR, tests are passing:
https://github.com/mayeut/packaging/actions/runs/1938654790

@mayeut mayeut marked this pull request as draft April 2, 2022 12:35
@mayeut
Copy link
Contributor Author

mayeut commented Apr 2, 2022

let's go back to draft until PyPy 7.3.9 rollout is complete on GHA hosted runners.

@mayeut mayeut force-pushed the install-pypyX.Y-symlinks branch from e621a16 to 156f48c Compare April 2, 2022 12:36
`pypyX.Y.exe` executables are missing from PyPy archives on Windows before v7.3.9 (X.Y < 3.9) `pypy2.7` symlinks are also missing from macOS/Linux PyPy archives before v7.3.9 relates to actions#346
@mayeut mayeut force-pushed the install-pypyX.Y-symlinks branch from 156f48c to 8d0fdb2 Compare April 9, 2022 09:26
@mayeut
Copy link
Contributor Author

mayeut commented Apr 9, 2022

PyPy 7.3.9 rollout is now complete on GHA hosted runners.

@mayeut mayeut marked this pull request as ready for review April 9, 2022 09:40
@mayeut mayeut requested a review from a team April 9, 2022 09:40
@mayeut
Copy link
Contributor Author

mayeut commented Apr 28, 2022

@marko-zivic-93, @dmitry-shibanov,

anything else I need to do to get this moving forward ? This PR is a pre-requisite for #346 & #349.

@brcrista brcrista merged commit 1ce3088 into actions:main Apr 28, 2022
@mayeut mayeut deleted the install-pypyX.Y-symlinks branch April 28, 2022 15:57
tdfacer pushed a commit to ifit/setup-python that referenced this pull request Oct 7, 2025
`pypyX.Y.exe` executables are missing from PyPy archives on Windows before v7.3.9 (X.Y < 3.9) `pypy2.7` symlinks are also missing from macOS/Linux PyPy archives before v7.3.9 relates to actions#346
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants