Skip to content

Commit c132f3b

Browse files
committed
KT-19276: Drop exception logging on loading script definitions failure
See YT discussion Have to come up with more meaningful diagnostics on definition loading #KT-19276 Fixed
1 parent 6424b67 commit c132f3b

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

compiler/frontend.script/src/org/jetbrains/kotlin/script/scriptTemplateProviderExtensionPoint.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ interface ScriptTemplatesProvider {
6161
}
6262

6363
fun makeScriptDefsFromTemplatesProviderExtensions(project: Project,
64-
errorsHandler: ((ScriptTemplatesProvider, Throwable) -> Unit) = { _, ex -> throw ex }
64+
errorsHandler: ((ScriptTemplatesProvider, Throwable) -> Unit)
6565
): List<KotlinScriptDefinition> =
6666
makeScriptDefsFromTemplatesProviders(Extensions.getArea(project).getExtensionPoint(ScriptTemplatesProvider.EP_NAME).extensions.asIterable(),
6767
errorsHandler)

idea/idea-core/src/org/jetbrains/kotlin/idea/core/script/ScriptDependenciesManager.kt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,9 @@ class ScriptDependenciesManager internal constructor(
5454
fun getScriptDependencies(file: VirtualFile) = cacheUpdater.getCurrentDependencies(file)
5555

5656
private fun reloadScriptDefinitions() {
57-
val def = makeScriptDefsFromTemplatesProviderExtensions(project, { ep, ex -> log.warn("[kts] Error loading definition from ${ep.id}", ex) })
57+
val def = makeScriptDefsFromTemplatesProviderExtensions(
58+
project, { ep, ex -> /* do nothing, logging these exception creates too much noise*/}
59+
)
5860
scriptDefinitionProvider.setScriptDefinitions(def)
5961
}
6062

0 commit comments

Comments
 (0)