Skip to content

Conversation

@navin772
Copy link
Member

@navin772 navin772 commented Jun 5, 2025

User description

🔗 Related Issues

💥 What does this PR do?

Enables bidi storage test - test_get_all_cookies for Edge browser.

🔧 Implementation Notes

💡 Additional Considerations

🔄 Types of changes

  • Cleanup (formatting, renaming)

PR Type

Tests


Description

  • Enable BiDi storage test test_get_all_cookies for Edge

  • Remove xfail_edge marker from the test


Changes walkthrough 📝

Relevant files
Tests
bidi_storage_tests.py
Enable Edge for BiDi storage test_get_all_cookies               

py/test/selenium/webdriver/common/bidi_storage_tests.py

  • Removed the @pytest.mark.xfail_edge decorator from
    test_get_all_cookies
  • Now runs this test for Edge browser as well
  • +0/-1     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • @selenium-ci selenium-ci added the C-py Python Bindings label Jun 5, 2025
    @qodo-merge-pro
    Copy link
    Contributor

    qodo-merge-pro bot commented Jun 5, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    🎫 Ticket compliance analysis ❌

    5678 - Not compliant

    Non-compliant requirements:

    • Fix the "Error: ConnectFailure (Connection refused)" issue when instantiating ChromeDriver multiple times

    Requires further human verification:

    • The PR is about Edge BiDi storage tests and doesn't address the ChromeDriver connection issue

    1234 - Not compliant

    Non-compliant requirements:

    • Fix issue where JavaScript in link's href is not triggered on click() in Firefox 42.0

    Requires further human verification:

    • The PR is about Edge BiDi storage tests and doesn't address the Firefox click() issue

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 PR contains tests
    🔒 No security concerns identified
    ⚡ No major issues detected
    @qodo-merge-pro
    Copy link
    Contributor

    qodo-merge-pro bot commented Jun 5, 2025

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    2 participants