Skip to content

Conversation

@cgoldberg
Copy link
Member

@cgoldberg cgoldberg commented May 29, 2025

User description

💥 What does this PR do?

Fixes type hint import so Generator is imported from collections.abc instead of typing.

🔄 Types of changes

  • Bug fix (backwards compatible)

PR Type

Bug fix


Description

  • Fix import of Generator for type hinting

  • Use collections.abc instead of deprecated typing


Changes walkthrough 📝

Relevant files
Bug fix
common.py
Corrected `Generator` import for type hinting                       

py/selenium/webdriver/common/bidi/common.py

  • Changed import of Generator from typing to collections.abc
  • Ensured type hinting uses the correct module
  • +3/-1     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • @qodo-merge-pro
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected
    @selenium-ci selenium-ci added C-py Python Bindings B-devtools Includes everything BiDi or Chrome DevTools related labels May 29, 2025
    @qodo-merge-pro
    Copy link
    Contributor

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    2 participants