Skip to content

Conversation

@diemol
Copy link
Member

@diemol diemol commented May 7, 2025

User description

🔗 Related Issues

None

💥 What does this PR do?

Removing deprecated items for a long time in the Require internal class.

🔧 Implementation Notes

💡 Additional Considerations

🔄 Types of changes

  • Cleanup (formatting, renaming)
  • Bug fix (backwards compatible)
  • New feature (non-breaking change which adds functionality and tests!)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR Type

Enhancement


Description

  • Remove deprecated FileChecker and FileStateChecker classes

  • Eliminate deprecated file-related argument and state methods

  • Clean up imports and internal API surface


Changes walkthrough 📝

Relevant files
I-cleanup
Require.java
Remove deprecated file-based checkers and methods               

java/src/org/openqa/selenium/internal/Require.java

  • Removed deprecated FileChecker and FileStateChecker classes
  • Deleted deprecated argument and state methods for File
  • Cleaned up unused imports related to File
  • Updated internal API to rely on Path-based checks
  • +0/-105 

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • @selenium-ci selenium-ci added the C-java Java Bindings label May 7, 2025
    @qodo-merge-pro
    Copy link
    Contributor

    qodo-merge-pro bot commented May 7, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    🎫 Ticket compliance analysis ❌

    1234 - Not compliant

    Non-compliant requirements:

    • Fix issue where JavaScript in link's href is not triggered on click() in Firefox 42.0 with Selenium 2.48.0/2.48.2
    • Ensure compatibility with Firefox 42.0 32bit on 64bit machine

    5678 - Not compliant

    Non-compliant requirements:

    • Fix "Error: ConnectFailure (Connection refused)" when instantiating ChromeDriver after the first instance
    • Ensure compatibility with Chrome 65.0.3325.181 and ChromeDriver 2.35
    • Fix issues on Ubuntu 16.04.4 with Linux 4.10.0 and Selenium 3.9.0

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected
    @qodo-merge-pro
    Copy link
    Contributor

    qodo-merge-pro bot commented May 7, 2025

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    3 participants