test: Fix result randomness in RunnerTest for MacOS #9139
Merged
+9 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Oh wow, a parallel runner inside a test inside a parallel test runner, this is tricky! 😅 Unfortunately I switched to a Mac this year, so I fear I cannot reproduce this locally, but I'll try to take a look when I can to see if I can spot anything from the code... |
kubawerlos approved these changes Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This little improvement should make this test stable for MacOS (I did few re-runs and it passed every time).
Unfortunately, there still is a problem for Linux, but it's NOT related to test itself, because as you can see here, when running with native PHPUnit, it passes for all matrix' test jobs (failures are only because of output printed from debug
echostatements). No timeouts there. Only when run through ParaUnit, it randomly hits timeouts, or runs endlessly whenenforceTimeLimitis set tofalse. Those endless runs may stuck both at the end of the test (after ReactPHP's loop is theoretically finished and test should reach assertion phase) or even before it starts anything (no debug output).At this point I have no idea what can be done to make it stable on Linux. @Jean85 any thoughts from ParaUnit perspective?