IsArray option isn't parsing tags with 0 as value correctly #490 #557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Can you please add a test for the same? |
I added a test to check this feature. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Purpose / Goal
This is fix for isArray option isn't parsing tags with 0 as value correctly. This only affected when we are parsing tags, not attributes.
The problem is that
obj[options.textNodeName]is checking the value exist, but if itfalseor0it will fail the test.So you can try to fix it to test it also for boolean type or zero.
The opened issue is #490
Type
Please mention the type of PR