fix unused variable prevent string enforcement #385
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There was the call
const csv = csvString.toString();which enforces the input offromString()to be a string. But the variablecsvwas never used which is why I got the errorcsvString.substr is not a functiondeep in a subdependency.I changed the code to actually use the string enforcement in the later calls.
What do you think about adding a tslint to the CI to prevent these kind of bugs in the future?