http: better debugging message for ByteArrayContent

https://codereview.appspot.com/8914043/

Author: Yaniv Inbar

google-http-client/src/main/java/com/google/api/client/http/ByteArrayContent.java

@@ -78,7 +78,8 @@ public ByteArrayContent(String type, byte[] array) {
  public ByteArrayContent(String type, byte[] array, int offset, int length) {
  super(type);
  this.byteArray = Preconditions.checkNotNull(array);
- Preconditions.checkArgument(offset >= 0 && length >= 0 && offset + length <= array.length);
+ Preconditions.checkArgument(offset >= 0 && length >= 0 && offset + length <= array.length,
+ "offset %s, length %s, array length %s", offset, length, array.length);
  this.offset = offset;
  this.length = length;
  }

google-http-client/src/test/java/com/google/api/client/http/ByteArrayContentTest.java

@@ -40,18 +40,21 @@ public void testConstructor() throws IOException {
  fail("expected " + IllegalArgumentException.class);
  } catch (IllegalArgumentException e) {
  // expected
+ assertEquals("offset -1, length 2, array length 3", e.getMessage());
  }
  try {
  new ByteArrayContent(null, FOO, 2, 2);
  fail("expected " + IllegalArgumentException.class);
  } catch (IllegalArgumentException e) {
  // expected
+ assertEquals("offset 2, length 2, array length 3", e.getMessage());
  }
  try {
  new ByteArrayContent(null, FOO, 3, 1);
  fail("expected " + IllegalArgumentException.class);
  } catch (IllegalArgumentException e) {
  // expected
+ assertEquals("offset 3, length 1, array length 3", e.getMessage());
  }
  }