Skip to content

Conversation

purple4reina
Copy link
Contributor

What does this PR do?

Removes \*.c \*.cpp \*.cc \*.h \*.hpp \*.pyx files from ddtrace during build.

Motivation

When building ddtrace from a branch, it does not perform all the build steps that it would when publishing to PyPI. A missing step is to remove extra source files.

Testing Guidelines

Make sure integration tests pass.

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)
@purple4reina purple4reina requested a review from a team as a code owner April 30, 2024 16:02
@purple4reina purple4reina merged commit 3c79531 into main Apr 30, 2024
@purple4reina purple4reina deleted the rey.abolofia/strip branch April 30, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants