Gracefully handle old interaction format #7731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
konstantin-msft commented May 2, 2025
konstantin-msft commented - Gracefully handle old interaction format
konstantin-msft requested review from hectormmg, jo-arroyo, lalimasharda, peterzenz, sameerag, shylasummers and tnorling as code owners 
2 tasks
peterzenz previously approved these changes May 2, 2025
| try { | ||
| return value ? JSON.parse(value) : null; | ||
| } catch (e) { | ||
| // Remove interaction and other temp keys when redirect begins on version <4.10.0 and completes on 4.10.0+ |
Contributor
There was a problem hiding this comment.
This comment isn't really accurate here. You're not checking versions explicitly, you're really saying if I can't parse the old state then let's clean it up for a subsequent go. We can note for historic reasons that there we a break in 4.10.0 that needs this.
Collaborator Author
There was a problem hiding this comment.
Updated the comment
tnorling reviewed May 2, 2025
| return value ? JSON.parse(value) : null; | ||
| } catch (e) { | ||
| // Remove interaction and other temp keys when redirect begins on version <4.10.0 and completes on 4.10.0+ | ||
| this.removeTemporaryItem(key); |
Collaborator
There was a problem hiding this comment.
We should add a warning log here
tnorling reviewed May 2, 2025
| // Remove interaction and other temp keys when redirect begins on version <4.10.0 and completes on 4.10.0+ | ||
| this.removeTemporaryItem(key); | ||
| this.resetRequestCache(); | ||
| return null; |
Collaborator
There was a problem hiding this comment.
Is the auth code still in the url if I get into this state?
Collaborator Author
There was a problem hiding this comment.
Good catch. Added hash clean up as well
tnorling approved these changes May 2, 2025
jo-arroyo approved these changes May 2, 2025
peterzenz approved these changes May 2, 2025
jo-arroyo pushed a commit that referenced this pull request May 19, 2025
- Gracefully handle old interaction format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.