chore: Clean up release/v1.4 references in master due to EOL #3884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR performs EOL (End of Life) cleanup for the release/v1.4 branch by removing version references and dependency configurations that are no longer needed. The cleanup involves adding clarifying comments to hardcoded version references and removing dependabot configurations.
- Adds clarifying comments to hardcoded v1.4.x image versions across multiple YAML files to question if they need updating
- Removes dependabot configurations that were specifically targeting the release/v1.4 branch
- Completely removes a specific v1.4.39.1 YAML configuration file
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/kubemark/aks-e/azure-npm-with-kubemark.yaml | Added comment questioning if v1.4.9 image version needs updating |
| npm/examples/azure-npm-lite.yaml | Added comment questioning if v1.4.45.3 image version needs updating |
| npm/deploy/npm/azure-npm.yaml | Added comment questioning if v1.4.1 image version needs updating |
| npm/deploy/manifests/daemon/azure-npm.yaml | Added comment questioning if v1.4.1 image version needs updating |
| npm/deploy/manifests/controller/azure-npm.yaml | Added comment questioning if v1.4.1 image version needs updating |
| npm/deploy/kustomize/overlays/daemon/deployment.yaml | Added comment questioning if v1.4.1 image version needs updating |
| npm/deploy/kustomize/overlays/controller/deployment.yaml | Added comment questioning if v1.4.1 image version needs updating |
| npm/azure-npm.yaml | Added comment questioning if v1.4.45.3 image version needs updating |
| cns/azure-cns.yaml | Added comment questioning if v1.4.7 image version needs updating |
| cns/azure-cns-windows.yaml | Added misplaced comment on container name instead of image version |
| .pipelines/mdnc/azure-cns-cni.yaml | Added comment questioning if v1.4.32 image version needs updating |
| .pipelines/mdnc/azure-cns-cni-1.4.39.1.yaml | Completely removed the file containing v1.4.39.1 configuration |
| .github/dependabot.yaml | Removed dependabot configurations targeting release/v1.4 branch |
rbtr reviewed Aug 1, 2025
thomasricci approved these changes Aug 1, 2025
| Leaving comments on NPM related files for a follow up PR. |
rayaisaiah approved these changes Aug 1, 2025
| /azp run Azure Container Networking PR |
| Azure Pipelines successfully started running 1 pipeline(s). |
4 tasks
rbtr approved these changes Aug 5, 2025
github-merge-queue bot removed this pull request from the merge queue due to failed status checks NihaNallappagari pushed a commit to NihaNallappagari/azure-container-networking that referenced this pull request Sep 4, 2025
sivakami-projects pushed a commit that referenced this pull request Oct 23, 2025
* chore: remove release/v1.4 dependabot trigger * chore: remove clearly defined v1.4 files * chore: adjust versioning on example and test yamls? * chore: remove mdnc references
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Typical EOL cleanup:
Issue Fixed:
Requirements:
Notes: