types(querycursor): correct cursor async iterator type with populate() support #14384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
hasezoey approved these changes Feb 26, 2024
Collaborator
hasezoey left a comment
hasezoey left a comment There was a problem hiding this comment.
Looks good, some small suggestions / question
Co-authored-by: hasezoey <hasezoey@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix #14374
Summary
Right now, using
for awaitwith a cursor doesn't quite work in TypeScript: you getDocType[]rather thanResultType. Similarly, that meanspopulate<Paths>()doesn't work right withcursor().Examples