Skip to content

Commit 39de084

Browse files
authored
Merge pull request smarteist#131 from smarteist/dev
Dev
2 parents dc91fe4 + d3f924e commit 39de084

File tree

3 files changed

+13
-17
lines changed

3 files changed

+13
-17
lines changed

app/src/main/java/com/smarteist/imageslider/MainActivity.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,12 +38,13 @@ protected void onCreate(Bundle savedInstanceState) {
3838
sliderView.setIndicatorSelectedColor(Color.WHITE);
3939
sliderView.setIndicatorUnselectedColor(Color.GRAY);
4040
sliderView.setScrollTimeInSec(3);
41-
sliderView.setAutoCycle(false);
41+
sliderView.setAutoCycle(true);
42+
sliderView.startAutoCycle();
4243

4344
sliderView.setOnIndicatorClickListener(new DrawController.ClickListener() {
4445
@Override
4546
public void onIndicatorClicked(int position) {
46-
sliderView.setCurrentPagePosition(position);
47+
sliderView.slideToPreviousPosition();
4748
}
4849
});
4950

autoimageslider/src/main/java/com/smarteist/autoimageslider/SliderPager.java

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ public float getInterpolation(float t) {
101101
}
102102
};
103103

104-
private final ArrayList<ItemInfo> mItems = new ArrayList<ItemInfo>();
104+
private final ArrayList<ItemInfo> mItems = new ArrayList<>();
105105
private final ItemInfo mTempItem = new ItemInfo();
106106

107107
private final Rect mTempRect = new Rect();
@@ -351,7 +351,7 @@ void initSliderPager() {
351351
setDescendantFocusability(FOCUS_AFTER_DESCENDANTS);
352352
setFocusable(true);
353353
final Context context = getContext();
354-
mScroller = new Scroller(context, sInterpolator);
354+
mScroller = new OwnScroller(context, DEFAULT_SCROLL_DURATION, sInterpolator);
355355
final ViewConfiguration configuration = ViewConfiguration.get(context);
356356
final float density = context.getResources().getDisplayMetrics().density;
357357

@@ -875,11 +875,9 @@ protected boolean verifyDrawable(Drawable who) {
875875

876876
public void setScrollDuration(int millis, Interpolator interpolator) {
877877
if (interpolator != null) {
878-
OwnScroller ownScroller = new OwnScroller(getContext(), millis, interpolator);
879-
mScroller = ownScroller;
878+
mScroller = new OwnScroller(getContext(), millis, interpolator);
880879
} else {
881-
OwnScroller ownScroller = new OwnScroller(getContext(), millis);
882-
mScroller = ownScroller;
880+
mScroller = new OwnScroller(getContext(), millis);
883881
}
884882
}
885883

@@ -1409,7 +1407,7 @@ public String toString() {
14091407
+ " position=" + position + "}";
14101408
}
14111409

1412-
public static final Creator<SavedState> CREATOR = new ClassLoaderCreator<SavedState>() {
1410+
public static final Parcelable.Creator<SavedState> CREATOR = new Parcelable.ClassLoaderCreator<SavedState>() {
14131411
@Override
14141412
public SavedState createFromParcel(Parcel in, ClassLoader loader) {
14151413
return new SavedState(in, loader);
@@ -3109,7 +3107,7 @@ class OwnScroller extends Scroller {
31093107
private int durationScrollMillis;
31103108

31113109
OwnScroller(Context context, int durationScroll) {
3112-
super(context, new DecelerateInterpolator());
3110+
super(context, sInterpolator);
31133111
this.durationScrollMillis = durationScroll;
31143112
}
31153113

autoimageslider/src/main/java/com/smarteist/autoimageslider/SliderView.java

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -131,9 +131,7 @@ private void setUpAttributes(@NonNull Context context, AttributeSet attrs) {
131131
setIndicatorRadius(indicatorRadius);
132132
setIndicatorPadding(indicatorPadding);
133133
setIndicatorMargin(indicatorMargin);
134-
if(R.styleable.SliderView_sliderIndicatorMargin == null){
135-
setIndicatorMarginCustom(indicatorMarginLeft,indicatorMarginTop,indicatorMarginRight,indicatorMarginBottom);
136-
}
134+
setIndicatorMarginCustom(indicatorMarginLeft, indicatorMarginTop, indicatorMarginRight, indicatorMarginBottom);
137135
setIndicatorGravity(indicatorGravity);
138136
setIndicatorMargins(indicatorMarginLeft, indicatorMarginTop, indicatorMarginRight, indicatorMarginBottom);
139137
setIndicatorUnselectedColor(indicatorUnselectedColor);
@@ -200,6 +198,7 @@ public void setSliderAdapter(@NonNull SliderViewAdapter pagerAdapter) {
200198
//setup with indicator
201199
mPagerIndicator.setCount(getAdapterItemsCount());
202200
mPagerIndicator.setDynamicCount(true);
201+
setCurrentPagePosition(0);
203202
}
204203

205204
/**
@@ -210,9 +209,7 @@ public void setSliderAdapter(@NonNull SliderViewAdapter pagerAdapter, boolean in
210209
this.mIsInfiniteAdapter = infiniteAdapter;
211210
if (!infiniteAdapter) {
212211
this.mPagerAdapter = pagerAdapter;
213-
//registerAdapterDataObserver();
214212
mSliderPager.setAdapter(pagerAdapter);
215-
//setup with indicator
216213
mPagerIndicator.setCount(getAdapterItemsCount());
217214
mPagerIndicator.setDynamicCount(true);
218215
} else {
@@ -588,8 +585,8 @@ public void setIndicatorMargin(int margin) {
588585
layoutParams.setMargins(margin, margin, margin, margin);
589586
mPagerIndicator.setLayoutParams(layoutParams);
590587
}
591-
592-
public void setIndicatorMarginCustom(int left,int top,int right,int bottom) {
588+
589+
public void setIndicatorMarginCustom(int left, int top, int right, int bottom) {
593590
FrameLayout.LayoutParams layoutParams = (LayoutParams) mPagerIndicator.getLayoutParams();
594591
layoutParams.setMargins(left, top, right, bottom);
595592
mPagerIndicator.setLayoutParams(layoutParams);

0 commit comments

Comments
 (0)