TypeError: 'NoneType' object is not callable

[akbarza]

hi
when I ran the below code, I encountered with an error message. I searched the net and read some pages but I did not understand how to correct the code. any guidance appreciated
code:

## from: ## https://www.shabakeh-mag.com/workshop/20801/ ## %D8%AF%DA%A9%D9%88%D8%B1%D8%A7%D8%AA%D9%88%D8%B1%D9 ## %87%D8%A7-%D8%AF%D8%B1-%D9%BE%D8%A7%DB%8C%D8%AA%D9% ## 88%D9%86-%D9%88-%D9%86%D8%AD%D9%88%D9%87-%D9%BE%DB% ## 8C%D8%A7%D8%AF%D9%87%E2%80%8C%D8%B3%D8%A7%D8%B2%DB% ## 8C-%D8%A2%D9%86%E2%80%8C%D9%87%D8%A7 import time def memorize(func): cash={} def wrapper(*args): if args in cash: return cash[args] else: result=func(*args) cash[atgs]=result return result return wrapper def timed(func): def wrapper(*args): start= time.time() result=func(*args) end=time.time() print(f"Elapse time: {end - start:.6f seconds}") return result return wrapper @memorize @timed def sum_of_odd_numbers(n): return sum(filter(lambda x: x%2==1,range(n))) ##if callable(sum_of_odd_numbers(10)): ## print(" sum of odd numbers of 10: ",end="") ## print( sum_of_odd_numbers(10) ) ##else: ## print("The sum_of_odd_numbers(10) is not callable.") print(" sum of odd numbers of 10: ",end="") print( sum_of_odd_numbers(10) )

after running:

Error:
Traceback (most recent call last): File "D:\14020412_enteghal\akb_python\akb_py_projects\combined_decorator_example.py", line 42, in <module> if callable(sum_of_odd_numbers(10)): TypeError: 'NoneType' object is not callable

[deanhystad]

Both your decorators have errors

def memorize(func): cash={} def wrapper(*args): if args in cash: return cash[args] else: result=func(*args) cash[atgs]=result return result return wrapper # <-- Indentation error def timed(func): def wrapper(*args): start= time.time() result=func(*args) end=time.time() print(f"Elapse time: {end - start:.6f seconds}") # <- Format error return result return wrapper

Test your decorators one at a time.

[deanhystad]

I searched the net and read some pages but I did not understand how to correct the code.

I googled "TypeError: 'NoneType' object is not callable" and this was the very first hit.

https://www.geeksveda.com/typeerror-none...-callable/

“TypeError: 'nonetype' object is not callable” occurs when you try to call a None value as if it were a function. To solve it, make sure that you do not override the names of any functions with a None value.

This is exactly what you did here.

def memorize(func): cash={} def wrapper(*args): if args in cash: return cash[args] else: result=func(*args) cash[atgs]=result return result return wrapper # <-- Indentation error

Because of the indentation error, calling memorize(sum_of_odd_numbers) returns None when you wanted it to return sum_ov_numbers.wrapper. This means when you called sum_of_odd_numbers(10) you ended up calling None(10).

[deanhystad]

Noticed another error:

def memorize(func): cash={} def wrapper(*args): if args in cash: return cash[args] else: result=func(*args) cash[atgs]=result # <- Should be args, not atgs return result return wrapper # <- Indenting is still wrong

[snippsat]

The site you get code from use plain HTML without even a <code> tag to display the code this is bad.
Usually if make a site where people post a lot of code,then have some kind of code box.
If look at source eg:

<span style="background-color:#ffffcc">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; cache[args] = result</span>

A overflow of &nbsp💥
So can get strange result if try to copy code,look like you have written the code over as there are typo's to.
The code work,here a cleaned up versions and i made a few changes.

import time def memoize(func): cache = {} def wrapper(*args): if args not in cache: cache[args] = func(*args) return cache[args] return wrapper def timed(func): def wrapper(*args): start = time.time() result = func(*args) end = time.time() elapsed_time = end - start print(f"Elapsed time: {elapsed_time:.6f} seconds") return result return wrapper @memoize @timed def sum_of_odd_numbers(n): return sum(x for x in range(n) if x % 2 == 1) print(sum_of_odd_numbers(10000000)) print(sum_of_odd_numbers(10000000))

Output:
Elapsed time: 0.759998 seconds 25000000000000 25000000000000