changeset:   96914:0b04e5689c33
parent:      96912:a4fe32477df6
parent:      96913:fce682a493e7
user:        Serhiy Storchaka <storchaka@gmail.com>
date:        Wed Jul 15 22:12:33 2015 +0300
files:       Misc/NEWS
description:
Issue #24631: Fixed regression in the timeit modulu with multyline setup.


diff -r a4fe32477df6 -r 0b04e5689c33 Lib/test/test_timeit.py
--- a/Lib/test/test_timeit.py	Wed Jul 15 11:51:22 2015 +1200
+++ b/Lib/test/test_timeit.py	Wed Jul 15 22:12:33 2015 +0300
@@ -88,8 +88,8 @@
         self.assertRaises(SyntaxError, timeit.Timer, setup='continue')
         self.assertRaises(SyntaxError, timeit.Timer, setup='from timeit import *')
 
-    fake_setup = "import timeit; timeit._fake_timer.setup()"
-    fake_stmt = "import timeit; timeit._fake_timer.inc()"
+    fake_setup = "import timeit\ntimeit._fake_timer.setup()"
+    fake_stmt = "import timeit\ntimeit._fake_timer.inc()"
 
     def fake_callable_setup(self):
         self.fake_timer.setup()
@@ -272,6 +272,12 @@
         self.assertEqual(s, "CustomSetup\n" * 3 +
                 "35 loops, best of 3: 2 sec per loop\n")
 
+    def test_main_multiple_setups(self):
+        s = self.run_main(seconds_per_increment=2.0,
+                switches=['-n35', '-s', 'a = "CustomSetup"', '-s', 'print(a)'])
+        self.assertEqual(s, "CustomSetup\n" * 3 +
+                "35 loops, best of 3: 2 sec per loop\n")
+
     def test_main_fixed_reps(self):
         s = self.run_main(seconds_per_increment=60.0, switches=['-r9'])
         self.assertEqual(s, "10 loops, best of 9: 60 sec per loop\n")
diff -r a4fe32477df6 -r 0b04e5689c33 Lib/timeit.py
--- a/Lib/timeit.py	Wed Jul 15 11:51:22 2015 +1200
+++ b/Lib/timeit.py	Wed Jul 15 22:12:33 2015 +0300
@@ -109,19 +109,18 @@
         if isinstance(setup, str):
             # Check that the code can be compiled outside a function
             compile(setup, dummy_src_name, "exec")
+            stmtprefix = setup + '\n'
             setup = reindent(setup, 4)
         elif callable(setup):
             local_ns['_setup'] = setup
             init += ', _setup=_setup'
+            stmtprefix = ''
             setup = '_setup()'
         else:
             raise ValueError("setup is neither a string nor callable")
         if isinstance(stmt, str):
             # Check that the code can be compiled outside a function
-            if isinstance(setup, str):
-                compile(setup + '\n' + stmt, dummy_src_name, "exec")
-            else:
-                compile(stmt, dummy_src_name, "exec")
+            compile(stmtprefix + stmt, dummy_src_name, "exec")
             stmt = reindent(stmt, 8)
         elif callable(stmt):
             local_ns['_stmt'] = stmt
diff -r a4fe32477df6 -r 0b04e5689c33 Misc/NEWS
--- a/Misc/NEWS	Wed Jul 15 11:51:22 2015 +1200
+++ b/Misc/NEWS	Wed Jul 15 22:12:33 2015 +0300
@@ -39,6 +39,8 @@
 Library
 -------
 
+- Issue #24631: Fixed regression in the timeit modulu with multyline setup.
+
 - Issue #24608: chunk.Chunk.read() now always returns bytes, not str.
 
 - Issue #18684: Fixed reading out of the buffer in the re module.