core/views/run: Show transparency setting in About popup.

The Controller now accepts the transparency parameter from the configuration in run.py, storing it and passing it to the About popup as required. Tests updated.

Author: neiljp

tests/core/test_core.py

@@ -51,6 +51,7 @@ def controller(self, mocker: MockerFixture) -> Controller:
  self.autohide = True # FIXME Add tests for no-autohide
  self.notify_enabled = False
  self.exit_confirmation = True
+ self.transparency_enabled = False
  self.maximum_footlinks = 3
  result = Controller(
  config_file=self.config_file,
@@ -64,6 +65,7 @@ def controller(self, mocker: MockerFixture) -> Controller:
  autohide=self.autohide,
  notify=self.notify_enabled,
  exit_confirmation=self.exit_confirmation,
+ transparency=self.transparency_enabled,
  ),
  )
  result.view.message_view = mocker.Mock() # set in View.__init__

tests/ui_tools/test_popups.py

@@ -207,6 +207,7 @@ def mock_external_classes(self, mocker: MockerFixture) -> None:
  autohide_enabled=False,
  maximum_footlinks=3,
  exit_confirmation_enabled=False,
+ transparency_enabled=False,
  )
 
  @pytest.mark.parametrize(
@@ -257,6 +258,7 @@ def test_feature_level_content(
  autohide_enabled=False,
  maximum_footlinks=3,
  exit_confirmation_enabled=False,
+ transparency_enabled=False,
  )
 
  assert len(about_view.feature_level_content) == (
@@ -293,6 +295,7 @@ def test_copied_content(self) -> None:
 Color depth: 256
 Notifications: disabled
 Exit confirmation: disabled
+Transparency: disabled
 
 #### Detected Environment
 Platform: WSL

zulipterminal/cli/run.py

@@ -596,9 +596,6 @@ def print_setting(setting: str, data: SettingData, suffix: str = "") -> None:
  transparent_background=transparency_enabled,
  )
 
- # Avoid passing this to the Controller
- boolean_settings.pop("transparency")
-
  Controller(
  config_file=zuliprc_path,
  maximum_footlinks=maximum_footlinks,

zulipterminal/core.py

@@ -70,6 +70,7 @@ def __init__(
  color_depth: int,
  debug_path: Optional[str],
  in_explore_mode: bool,
+ transparency: bool,
  autohide: bool,
  notify: bool,
  exit_confirmation: bool,
@@ -78,6 +79,7 @@ def __init__(
  self.theme = theme
  self.color_depth = color_depth
  self.in_explore_mode = in_explore_mode
+ self.transparency_enabled = transparency
  self.autohide = autohide
  self.exit_confirmation = exit_confirmation
  self.notify_enabled = notify
@@ -310,6 +312,7 @@ def show_about(self) -> None:
  autohide_enabled=self.autohide,
  maximum_footlinks=self.maximum_footlinks,
  exit_confirmation_enabled=self.exit_confirmation,
+ transparency_enabled=self.transparency_enabled,
  ),
  "area:help",
  )

zulipterminal/ui_tools/views.py

@@ -1091,6 +1091,7 @@ def __init__(
  maximum_footlinks: int,
  notify_enabled: bool,
  exit_confirmation_enabled: bool,
+ transparency_enabled: bool,
  ) -> None:
  self.feature_level_content = (
  [("Feature level", str(server_feature_level))]
@@ -1113,6 +1114,7 @@ def __init__(
  "Exit confirmation",
  "enabled" if exit_confirmation_enabled else "disabled",
  ),
+ ("Transparency", "enabled" if transparency_enabled else "disabled"),
  ],
  ),
  (