fix(typescript): Extend no-shadow allow list to accommodate common patterns

Author: evocateur

packages/eslint-config-zillow-typescript/rules/all-remaining.js

@@ -245,7 +245,12 @@ module.exports = {
  // eslint core
  builtinGlobals: true,
  hoist: 'functions',
- allow: [],
+ allow: [
+ // ponyfills
+ 'fetch',
+ // namespace declaration merging
+ 'global',
+ ],
  // this plugin
  ignoreTypeValueShadow: true,
  ignoreFunctionTypeParameterNameValueShadow: true,

packages/eslint-plugin-zillow/test/__snapshots__/eslint-plugin-zillow.test.js.snap

@@ -3339,7 +3339,10 @@ Object {
  "zillow/@typescript-eslint/no-shadow": Array [
  "error",
  Object {
- "allow": Array [],
+ "allow": Array [
+ "fetch",
+ "global",
+ ],
  "builtinGlobals": true,
  "hoist": "functions",
  "ignoreFunctionTypeParameterNameValueShadow": true,