Skip to content

Commit 593f86f

Browse files
authored
Adds NoOpTracerProvider test case for pymysql instrumentation (open-telemetry#2581)
1 parent a166208 commit 593f86f

File tree

1 file changed

+15
-0
lines changed

1 file changed

+15
-0
lines changed

instrumentation/opentelemetry-instrumentation-pymysql/tests/test_pymysql_integration.py

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
import pymysql
1818

1919
import opentelemetry.instrumentation.pymysql
20+
from opentelemetry import trace as trace_api
2021
from opentelemetry.instrumentation.pymysql import PyMySQLInstrumentor
2122
from opentelemetry.sdk import resources
2223
from opentelemetry.test.test_base import TestBase
@@ -78,6 +79,20 @@ def test_custom_tracer_provider(self, mock_connect):
7879

7980
self.assertIs(span.resource, resource)
8081

82+
@mock.patch("pymysql.connect")
83+
# pylint: disable=unused-argument
84+
def test_no_op_tracer_provider(self, mock_connect):
85+
PyMySQLInstrumentor().instrument(
86+
tracer_provider=trace_api.NoOpTracerProvider()
87+
)
88+
cnx = pymysql.connect(database="test")
89+
cursor = cnx.cursor()
90+
query = "SELECT * FROM test"
91+
cursor.execute(query)
92+
93+
spans_list = self.memory_exporter.get_finished_spans()
94+
self.assertEqual(len(spans_list), 0)
95+
8196
@mock.patch("pymysql.connect")
8297
# pylint: disable=unused-argument
8398
def test_instrument_connection(self, mock_connect):

0 commit comments

Comments
 (0)