Skip to content

Commit 680a5b8

Browse files
authored
[MRG + 1] DOC Add whatsnew for the 3 model_selection bugfixes (scikit-learn#7868)
* DOC Add whatnew for the 3 mod-sel bugfixes * Move to 0.18.1; Change name universally to Raghav RV * Raghav R V --> Raghav RV * Edit mailmap to include my other email
1 parent 38ca830 commit 680a5b8

File tree

4 files changed

+32
-15
lines changed

4 files changed

+32
-15
lines changed

.mailmap

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,8 @@ Olivier Grisel <olivier.grisel@ensta.org> <olivier.grisel@ensta.org>
9393
Olivier Hervieu <olivier.hervieu@gmail.com> <olivier.hervieu@tinyclues.com>
9494
Paul Butler <paulgb@gmail.com>
9595
Peter Prettenhofer <peter.prettenhofer@gmail.com>
96-
Raghav R V <rvraghav93@gmail.com>
96+
Raghav RV <rvraghav93@gmail.com>
97+
Raghav RV <rvraghav93@gmail.com> <ragvrv@gmail.com>
9798
Robert Layton <robertlayton@gmail.com>
9899
Roman Sinayev <roman.sinayev@gmail.com>
99100
Roman Sinayev <roman.sinayev@gmail.com> <roman@y570.(none)>

doc/about.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ Environment also funds several students to work on the project part-time.
9696
:target: http://cds.nyu.edu/mooresloan/
9797

9898
`Télécom Paristech <http://www.telecom-paristech.com>`_ funds Manoj Kumar (2014),
99-
Tom Dupré la Tour (2015), Raghav R V (2015-2016) and Thierry Guillemot (2016) to
99+
Tom Dupré la Tour (2015), Raghav RV (2015-2016) and Thierry Guillemot (2016) to
100100
work on scikit-learn.
101101

102102
.. image:: themes/scikit-learn/static/img/telecom.png
@@ -114,7 +114,7 @@ program.
114114
- 2012 - `Vlad Niculae`_, Immanuel Bayer.
115115
- 2013 - Kemal Eren, Nicolas Trésegnie
116116
- 2014 - Hamzeh Alsalhi, Issam Laradji, Maheshakya Wijewardena, Manoj Kumar.
117-
- 2015 - `Raghav R V <https://github.com/raghavrv>`_, Wei Xue
117+
- 2015 - `Raghav RV <https://github.com/raghavrv>`_, Wei Xue
118118
- 2016 - `Nelson Liu <http://nelsonliu.me>`_, `YenChen Lin <http://yclin.me>`_
119119

120120
It also provided funding for sprints and events around scikit-learn. If

doc/whats_new.rst

Lines changed: 27 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -162,6 +162,22 @@ Bug fixes
162162
has less number of classes than the total data. :issue:`7799` by
163163
`Srivatsan Ramesh`_
164164

165+
- Fixed a bug where :func:`sklearn.model_selection.train_test_split` raised
166+
an error when ``stratify`` is a list of string labels. :issue:`7593` by
167+
`Raghav RV`_.
168+
169+
- Fixed a bug where :class:`sklearn.model_selection.GridSearchCV` and
170+
:class:`sklearn.model_selection.RandomizedSearchCV` were not pickleable
171+
because of a pickling bug in ``np.ma.MaskedArray``. :issue:`7594` by
172+
`Raghav RV`_.
173+
174+
- All cross-validation utilities in :mod:`sklearn.model_selection` now
175+
permit one time cross-validation splitters for the ``cv`` parameter. Also
176+
non-deterministic cross-validation splitters (where multiple calls to
177+
``split`` produce dissimilar splits) can be used as ``cv`` parameter.
178+
The :class:`sklearn.model_selection.GridSearchCV` will cross-validate each
179+
parameter setting on the split produced by the first ``split`` call
180+
to the cross-validation splitter. :issue:`7660` by `Raghav RV`_.
165181

166182
API changes summary
167183
-------------------
@@ -357,7 +373,7 @@ Model selection and evaluation
357373
- The cross-validation iterators are replaced by cross-validation splitters
358374
available from :mod:`sklearn.model_selection`, allowing for nested
359375
cross-validation. See :ref:`model_selection_changes` for more information.
360-
:issue:`4294` by `Raghav R V`_.
376+
:issue:`4294` by `Raghav RV`_.
361377

362378
Enhancements
363379
............
@@ -474,7 +490,7 @@ Model evaluation and meta-estimators
474490
- The new ``cv_results_`` attribute of :class:`model_selection.GridSearchCV`
475491
(and :class:`model_selection.RandomizedSearchCV`) can be easily imported
476492
into pandas as a ``DataFrame``. Ref :ref:`model_selection_changes` for
477-
more information. :issue:`6697` by `Raghav R V`_.
493+
more information. :issue:`6697` by `Raghav RV`_.
478494

479495
- Generalization of :func:`model_selection.cross_val_predict`.
480496
One can pass method names such as `predict_proba` to be used in the cross
@@ -484,7 +500,7 @@ Model evaluation and meta-estimators
484500
- The training scores and time taken for training followed by scoring for
485501
each search candidate are now available at the ``cv_results_`` dict.
486502
See :ref:`model_selection_changes` for more information.
487-
:issue:`7325` by :user:`Eugene Chen <eyc88>` and `Raghav R V`_.
503+
:issue:`7325` by :user:`Eugene Chen <eyc88>` and `Raghav RV`_.
488504

489505
Metrics
490506

@@ -499,7 +515,7 @@ Metrics
499515
:issue:`7419` by :user:`Gregory Stupp <stuppie>` and `Joel Nothman`_.
500516

501517
- Add ``sample_weight`` parameter to :func:`metrics.matthews_corrcoef`.
502-
By :user:`Jatin Shah <jatinshah>` and `Raghav R V`_.
518+
By :user:`Jatin Shah <jatinshah>` and `Raghav RV`_.
503519

504520
- Speed up :func:`metrics.silhouette_score` by using vectorized operations.
505521
By `Manoj Kumar`_.
@@ -730,13 +746,13 @@ Model evaluation and meta-estimators
730746
:mod:`sklearn.learning_curve` have been deprecated and the classes and
731747
functions have been reorganized into the :mod:`sklearn.model_selection`
732748
module. Ref :ref:`model_selection_changes` for more information.
733-
:issue:`4294` by `Raghav R V`_.
749+
:issue:`4294` by `Raghav RV`_.
734750

735751
- The ``grid_scores_`` attribute of :class:`model_selection.GridSearchCV`
736752
and :class:`model_selection.RandomizedSearchCV` is deprecated in favor of
737753
the attribute ``cv_results_``.
738754
Ref :ref:`model_selection_changes` for more information.
739-
:issue:`6697` by `Raghav R V`_.
755+
:issue:`6697` by `Raghav RV`_.
740756

741757
- The parameters ``n_iter`` or ``n_folds`` in old CV splitters are replaced
742758
by the new parameter ``n_splits`` since it can provide a consistent
@@ -757,7 +773,7 @@ Model evaluation and meta-estimators
757773
:class:`model_selection.LeavePGroupsOut` is renamed to
758774
``groups``. Additionally in :class:`model_selection.LeavePGroupsOut`,
759775
the parameter ``n_labels`` is renamed to ``n_groups``.
760-
:issue:`6660` by `Raghav R V`_.
776+
:issue:`6660` by `Raghav RV`_.
761777

762778
Code Contributors
763779
-----------------
@@ -1314,7 +1330,7 @@ Mathieu Blondel, Matt Krump, Matti Lyra, Maxim Kolganov, mbillinger, mhg,
13141330
Michael Heilman, Michael Patterson, Miroslav Batchkarov, Nelle Varoquaux,
13151331
Nicolas, Nikolay Mayorov, Olivier Grisel, Omer Katz, Óscar Nájera, Pauli
13161332
Virtanen, Peter Fischer, Peter Prettenhofer, Phil Roth, pianomania, Preston
1317-
Parry, Raghav R V, Rob Zinkov, Robert Layton, Rohan Ramanath, Saket Choudhary,
1333+
Parry, Raghav RV, Rob Zinkov, Robert Layton, Rohan Ramanath, Saket Choudhary,
13181334
Sam Zhang, santi, saurabh.bansod, scls19fr, Sebastian Raschka, Sebastian
13191335
Saeger, Shivan Sornarajah, SimonPL, sinhrks, Skipper Seabold, Sonny Hu, sseg,
13201336
Stephen Hoover, Steven De Gryze, Steven Seguin, Theodore Vasiloudis, Thomas
@@ -1542,7 +1558,7 @@ Enhancements
15421558
in their constructor. By `Manoj Kumar`_.
15431559

15441560
- Added decision function for :class:`multiclass.OneVsOneClassifier`
1545-
By `Raghav R V`_ and :user:`Kyle Beauchamp <kyleabeauchamp>`.
1561+
By `Raghav RV`_ and :user:`Kyle Beauchamp <kyleabeauchamp>`.
15461562

15471563
- :func:`neighbors.kneighbors_graph` and :func:`radius_neighbors_graph`
15481564
support non-Euclidean metrics. By `Manoj Kumar`_
@@ -1789,7 +1805,7 @@ API changes summary
17891805

17901806
- From now onwards, all estimators will uniformly raise ``NotFittedError``
17911807
(:class:`utils.validation.NotFittedError`), when any of the ``predict``
1792-
like methods are called before the model is fit. By `Raghav R V`_.
1808+
like methods are called before the model is fit. By `Raghav RV`_.
17931809

17941810
- Input data validation was refactored for more consistent input
17951811
validation. The ``check_arrays`` function was replaced by ``check_array``
@@ -4751,7 +4767,7 @@ David Huard, Dave Morrill, Ed Schofield, Travis Oliphant, Pearu Peterson.
47514767

47524768
.. _Noel Dawe: https://github.com/ndawe
47534769

4754-
.. _Raghav R V: https://github.com/raghavrv
4770+
.. _Raghav RV: https://github.com/raghavrv
47554771

47564772
.. _Tom Dupre la Tour: https://github.com/TomDLT
47574773

sklearn/model_selection/_split.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
# Author: Alexandre Gramfort <alexandre.gramfort@inria.fr>,
77
# Gael Varoquaux <gael.varoquaux@normalesup.org>,
88
# Olivier Grisel <olivier.grisel@ensta.org>
9-
# Raghav R V <rvraghav93@gmail.com>
9+
# Raghav RV <rvraghav93@gmail.com>
1010
# License: BSD 3 clause
1111

1212

0 commit comments

Comments
 (0)