Skip to content

Commit e6a5f9c

Browse files
fix spacing issues (microsoft#4980)
1 parent a0b33a7 commit e6a5f9c

File tree

6 files changed

+12
-13
lines changed

6 files changed

+12
-13
lines changed

news/2 Fixes/4979.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Fix cell spacing issues

src/datascience-ui/history-react/cell.css

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
grid-template-columns: auto 1fr;
2626
grid-column-gap: 3px;
2727
width: 100%;
28+
margin-top:16px;
2829
}
2930

3031
.content-div {
@@ -38,10 +39,6 @@
3839
display: grid;
3940
}
4041

41-
.hide {
42-
visibility: hidden;
43-
}
44-
4542
.cell-result-container {
4643
width: 100%;
4744
}

src/datascience-ui/history-react/code.css

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
.code-area {
3232
position: relative;
3333
width:100%;
34+
margin-bottom:16px;
3435
}
3536

3637
.code-area-editable {
@@ -45,8 +46,3 @@
4546
font-style: italic;
4647
color: var(--override-watermark-color, var(--vscode-pickerGroup-border));
4748
}
48-
49-
.hide {
50-
visibility: hidden;
51-
}
52-

src/datascience-ui/history-react/collapseButton.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export class CollapseButton extends React.Component<ICollapseButtonProps> {
2121

2222
public render() {
2323
const collapseInputPolygonClassNames = `collapse-input-svg ${this.props.open ? ' collapse-input-svg-rotate' : ''} collapse-input-svg-${this.props.theme}`;
24-
const collapseInputClassNames = `collapse-input remove-style ${this.props.visible ? '' : ' hide'}`;
24+
const collapseInputClassNames = `collapse-input remove-style ${this.props.visible ? '' : ' invisible'}`;
2525
// https://reactjs.org/docs/conditional-rendering.html#inline-if-with-logical--operator
2626
// Comment here just because the (boolean && statement) was new to me
2727
return (

src/datascience-ui/history-react/mainPanel.css

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,3 +15,11 @@
1515
background: var(--override-background, var(--vscode-editor-background));
1616
color: var(--override-foreground, var(--vscode-editor-foreground));
1717
}
18+
19+
.hide {
20+
display: none;
21+
}
22+
23+
.invisible {
24+
visibility: hidden;
25+
}

src/datascience-ui/history-react/variableExplorer.css

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,3 @@
88
right: 0;
99
background-color: var(--vscode-editor-background);
1010
}
11-
.hide {
12-
display: none;
13-
}

0 commit comments

Comments
 (0)