Fix intermittent test failures

Author: rchiodo

news/3 Code Health/4936.md

@@ -0,0 +1 @@
+Intermittent test failures with invalid objects.

news/3 Code Health/4951.md

@@ -0,0 +1 @@
+Test intermittent failures with jupyter kernel shutdown.

src/client/datascience/jupyter/jupyterServer.ts

@@ -574,7 +574,8 @@ export class JupyterServerBase implements INotebookServer {
  if (this.launchInfo && this.launchInfo.connectionInfo) {
  // If the server crashes, cancel the current observable
  exitHandlerDisposable = this.launchInfo.connectionInfo.disconnected((c) => {
- subscriber.error(this.sessionStartTime, new Error(localize.DataScience.jupyterServerCrashed().format(c.toString())));
+ const str = c ? c.toString() : '';
+ subscriber.error(this.sessionStartTime, new Error(localize.DataScience.jupyterServerCrashed().format(str)));
  subscriber.complete(this.sessionStartTime);
  });
  }

src/client/datascience/jupyter/jupyterSession.ts

@@ -20,6 +20,7 @@ import { callWithTimeout, sleep } from '../../common/utils/async';
 import * as localize from '../../common/utils/localize';
 import { noop } from '../../common/utils/misc';
 import { IConnection, IJupyterKernelSpec, IJupyterSession } from '../types';
+import { isTestExecution } from '../../common/constants';
 
 export class JupyterSession implements IJupyterSession {
  private connInfo: IConnection | undefined;
@@ -182,17 +183,17 @@ export class JupyterSession implements IJupyterSession {
  if (this.session) {
  try {
  // Shutdown may fail if the process has been killed
- await Promise.race([this.session.shutdown(), sleep(100)]);
+ await Promise.race([this.session.shutdown(), sleep(1000)]);
  } catch {
  noop();
  }
  // Dispose may not return. Wrap in a promise instead. Kernel futures can die if
  // process is already dead.
- if (this.session) {
+ if (this.session && !isTestExecution()) {
  await callWithTimeout(this.session.dispose.bind(this.session), 100);
  }
  }
- if (this.sessionManager) {
+ if (this.sessionManager && !isTestExecution()) {
  await callWithTimeout(this.sessionManager.dispose.bind(this.sessionManager), 100);
  }
  } catch {

src/test/datascience/mockLiveShare.ts

@@ -126,7 +126,10 @@ class Emitter<T> {
  if (typeof item.listener === 'function') {
  result = item.listener.call(undefined, item.event);
  } else {
- result = item.listener[0].call(item.listener[1], item.event);
+ const func = item.listener[0];
+ if (func) {
+ result = item.listener[0].call(item.listener[1], item.event);
+ }
  }
  }
  } catch (e) {