Fix full changelog URL + minor refactor (#331)

Co-authored-by: StyleCI Bot <bot@styleci.io>

Author: vjik

.github/workflows/build.yml

@@ -10,6 +10,8 @@ on:
  - 'psalm.xml'
 
  push:
+ branches:
+ - master
  paths-ignore:
  - 'docs/**'
  - 'README.md'

src/App/Command/Release/MakeCommand.php

@@ -7,7 +7,6 @@
 use Github\Api\Repository\Releases;
 use Github\AuthMethod;
 use Github\Client;
-use RuntimeException;
 use Symplify\GitWrapper\GitWorkingCopy;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
@@ -21,6 +20,7 @@
 use Yiisoft\YiiDevTool\App\Component\GitHubTokenAware;
 
 use function in_array;
+use function sprintf;
 
 final class MakeCommand extends PackageCommand
 {
@@ -61,9 +61,7 @@ protected function processPackage(Package $package): void
  $io = $this->getIO();
  $io->preparePackageHeader($package, 'Releasing {package}');
  $git = $package->getGitWorkingCopy();
-
- // Validate GitHub token at the very beginning
- $this->getGitHubToken();
+ $gitHubToken = $this->getGitHubToken();
 
  if (!$package->composerConfigFileExists()) {
  $io->warning([
@@ -180,7 +178,7 @@ protected function processPackage(Package $package): void
  $git->push();
  $git->pushTag((string) $versionToRelease);
 
- $this->releaseOnGithub($package, $versionToRelease);
+ $this->releaseOnGithub($gitHubToken, $package, $versionToRelease);
 
  $io->done();
 
@@ -241,28 +239,21 @@ private function getVersionToRelease(Version $currentVersion): Version
  return $nextVersion;
  }
 
- private function releaseOnGithub(Package $package, Version $versionToRelease): void
+ private function releaseOnGithub(string $token, Package $package, Version $versionToRelease): void
  {
  $io = $this->getIO();
  $io->info("Creating release on GitHub for $versionToRelease.\n");
 
  $client = new Client();
- try {
- $token = $this->getGitHubToken();
- } catch (RuntimeException $e) {
- $io->error($e->getMessage());
- $io->warning('Skipped creating release on GitHub.');
- return;
- }
  $changelogPath = $package->getPath() . '/CHANGELOG.md';
  $changelog = new Changelog($changelogPath);
  $client->authenticate($token, null, AuthMethod::ACCESS_TOKEN);
  $release = new Releases($client);
 
-
- $changelogUrl = "https://github.com/yiisoft/$packageName/blob/$versionToRelease/CHANGELOG.md";
  $body = implode("\n", $changelog->getReleaseNotes($versionToRelease));
- $body .= "\n\n[Full changelog]({$changelogUrl})";
+
+ $changelogUrl = "https://github.com/yiisoft/{$package->getName()}/blob/$versionToRelease/CHANGELOG.md";
+ $body .= "\n\n[Full changelog]($changelogUrl)";
 
  $release->create($package->getVendor(), $package->getId(), [
  'name' => sprintf('Version %s', $versionToRelease),