Test that Pool releases its semaphore after connection error. PYTHON-580

Author: ajdavis

test/test_pooling_base.py

@@ -999,6 +999,28 @@ def test_max_pool_size_with_end_request_only(self):
  # Call end_request() but not start_request()
  self._test_max_pool_size(0, 1)
 
+ def test_max_pool_size_with_connection_failure(self):
+ # The pool acquires its semaphore before attempting to connect; ensure
+ # it releases the semaphore on connection failure.
+ class TestPool(Pool):
+ def connect(self, pair):
+ raise socket.error()
+
+ test_pool = TestPool(
+ pair=('example.com', 27017),
+ max_size=1,
+ net_timeout=1,
+ conn_timeout=1,
+ use_ssl=False,
+ wait_queue_timeout=1,
+ use_greenlets=self.use_greenlets)
+
+ # First call to get_socket fails; if pool doesn't release its semaphore
+ # then the second call raises "ConnectionFailure: Timed out waiting for
+ # socket from pool" instead of the socket.error.
+ for i in range(2):
+ self.assertRaises(socket.error, test_pool.get_socket)
+
 
 class SocketGetter(MongoThread):
  """Utility for _TestMaxOpenSockets and _TestWaitQueueMultiple"""