Skip to content

Conversation

@alexvru
Copy link
Collaborator

@alexvru alexvru commented Sep 19, 2024

Changelog entry

Disable blob header by default in VDisk

Changelog category

  • Performance improvement

Additional information

Currently, VDisk prepends absolutely useless and obsolete 5-byte header to every blob, including huge ones. This setting disables this behavour.

@github-actions
Copy link

github-actions bot commented Sep 19, 2024

2024-09-19 09:58:46 UTC Pre-commit check linux-x86_64-release-asan for 6e90196 has started.
2024-09-19 09:58:56 UTC Artifacts will be uploaded here
2024-09-19 10:01:49 UTC ya make is running...
🔴 2024-09-19 11:44:29 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10776 10420 0 45 271 40

🟢 2024-09-19 11:45:28 UTC Build successful.
🟢 2024-09-19 11:46:02 UTC ydbd size 5.6 GiB changed* by +11.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 89c4688 merge: 6e90196 diff diff %
ydbd size 6 058 334 504 Bytes 6 058 346 528 Bytes +11.7 KiB +0.000%
ydbd stripped size 1 515 537 392 Bytes 1 515 539 696 Bytes +2.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 19, 2024

2024-09-19 09:59:48 UTC Pre-commit check linux-x86_64-release-clang14 for 6e90196 has started.
2024-09-19 09:59:57 UTC Artifacts will be uploaded here
2024-09-19 10:02:56 UTC ya make is running...
🟢 2024-09-19 10:10:14 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Sep 19, 2024

2024-09-19 10:00:06 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6e90196 has started.
2024-09-19 10:00:16 UTC Artifacts will be uploaded here
2024-09-19 10:03:07 UTC ya make is running...
🟡 2024-09-19 11:05:03 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15428 13897 0 30 1399 102

2024-09-19 11:06:22 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-09-19 11:17:49 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
159 (only retried tests) 41 0 24 2 92

2024-09-19 11:17:58 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-09-19 11:29:24 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
125 (only retried tests) 5 0 28 0 92

🟢 2024-09-19 11:29:31 UTC Build successful.
🟢 2024-09-19 11:30:22 UTC ydbd size 8.4 GiB changed* by +10.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 89c4688 merge: 6e90196 diff diff %
ydbd size 9 040 528 024 Bytes 9 040 538 536 Bytes +10.3 KiB +0.000%
ydbd stripped size 489 102 216 Bytes 489 103 048 Bytes +832 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

va-kuznecov
va-kuznecov previously approved these changes Sep 19, 2024
@github-actions
Copy link

github-actions bot commented Sep 20, 2024

2024-09-20 15:36:49 UTC Pre-commit check linux-x86_64-relwithdebinfo for e93fcd9 has started.
2024-09-20 15:36:52 UTC Artifacts will be uploaded here
2024-09-20 15:39:49 UTC ya make is running...
🟡 2024-09-20 16:47:34 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16325 14823 0 9 1392 101

2024-09-20 16:49:01 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-09-20 17:00:24 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
130 (only retried tests) 28 0 7 2 93

2024-09-20 17:00:32 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-09-20 17:11:51 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
109 (only retried tests) 5 0 11 0 93

🟢 2024-09-20 17:11:59 UTC Build successful.
🟢 2024-09-20 17:12:39 UTC ydbd size 8.4 GiB changed* by -5.1 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 06f4e89 merge: e93fcd9 diff diff %
ydbd size 9 043 469 168 Bytes 9 043 463 904 Bytes -5.1 KiB -0.000%
ydbd stripped size 489 388 296 Bytes 489 388 808 Bytes +512 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 20, 2024

2024-09-20 15:36:49 UTC Pre-commit check linux-x86_64-release-asan for e93fcd9 has started.
2024-09-20 15:36:53 UTC Artifacts will be uploaded here
2024-09-20 15:39:43 UTC ya make is running...
🔴 2024-09-20 17:29:23 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11681 11497 0 34 38 112

🟢 2024-09-20 17:30:24 UTC Build successful.
🟢 2024-09-20 17:31:06 UTC ydbd size 5.6 GiB changed* by +6.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 06f4e89 merge: e93fcd9 diff diff %
ydbd size 6 062 009 600 Bytes 6 062 015 896 Bytes +6.1 KiB +0.000%
ydbd stripped size 1 516 450 160 Bytes 1 516 450 480 Bytes +320 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 20, 2024

2024-09-20 15:36:50 UTC Pre-commit check linux-x86_64-release-clang14 for e93fcd9 has started.
2024-09-20 15:36:53 UTC Artifacts will be uploaded here
2024-09-20 15:39:54 UTC ya make is running...
🟢 2024-09-20 15:50:15 UTC Build successful.

@alexvru alexvru force-pushed the vdisk/disable-blob-header-by-default branch from 9c43769 to 50df805 Compare September 20, 2024 18:21
@github-actions
Copy link

github-actions bot commented Sep 20, 2024

2024-09-20 18:24:01 UTC Pre-commit check linux-x86_64-relwithdebinfo for d450c60 has started.
2024-09-20 18:24:11 UTC Artifacts will be uploaded here
2024-09-20 18:27:11 UTC ya make is running...
2024-09-20 18:53:03 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Sep 20, 2024

2024-09-20 18:24:09 UTC Pre-commit check linux-x86_64-release-clang14 for d450c60 has started.
2024-09-20 18:25:00 UTC Artifacts will be uploaded here
2024-09-20 18:28:27 UTC ya make is running...
🟢 2024-09-20 18:42:43 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Sep 20, 2024

2024-09-20 18:24:47 UTC Pre-commit check linux-x86_64-release-asan for d450c60 has started.
2024-09-20 18:24:57 UTC Artifacts will be uploaded here
2024-09-20 18:27:56 UTC ya make is running...
2024-09-20 18:52:50 UTC Check cancelled

@alexvru alexvru force-pushed the vdisk/disable-blob-header-by-default branch from 50df805 to f90895c Compare September 20, 2024 18:52
@github-actions
Copy link

github-actions bot commented Sep 20, 2024

2024-09-20 18:57:57 UTC Pre-commit check linux-x86_64-release-clang14 for cbd5435 has started.
2024-09-20 18:58:06 UTC Artifacts will be uploaded here
2024-09-20 19:00:59 UTC ya make is running...
🟢 2024-09-20 19:08:36 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Sep 20, 2024

2024-09-20 18:58:01 UTC Pre-commit check linux-x86_64-release-asan for cbd5435 has started.
2024-09-20 18:58:12 UTC Artifacts will be uploaded here
2024-09-20 19:01:04 UTC ya make is running...
🔴 2024-09-20 20:48:03 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11680 11310 0 51 274 45

🟢 2024-09-20 20:49:03 UTC Build successful.
🟡 2024-09-20 20:49:35 UTC ydbd size 5.6 GiB changed* by +155.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 8ec93b0 merge: cbd5435 diff diff %
ydbd size 6 063 001 616 Bytes 6 063 160 960 Bytes +155.6 KiB +0.003%
ydbd stripped size 1 516 681 744 Bytes 1 516 715 472 Bytes +32.9 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 20, 2024

2024-09-20 19:00:31 UTC Pre-commit check linux-x86_64-relwithdebinfo for cbd5435 has started.
2024-09-20 19:00:41 UTC Artifacts will be uploaded here
2024-09-20 19:03:32 UTC ya make is running...
🟡 2024-09-20 20:09:22 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16333 14628 0 12 1639 54

2024-09-20 20:10:44 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-09-20 20:21:57 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
336 (only retried tests) 231 0 5 9 91

2024-09-20 20:22:06 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-09-20 20:33:12 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
105 (only retried tests) 6 0 8 0 91

🟢 2024-09-20 20:33:19 UTC Build successful.
🟡 2024-09-20 20:34:01 UTC ydbd size 8.4 GiB changed* by +171.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 8ec93b0 merge: cbd5435 diff diff %
ydbd size 9 044 913 968 Bytes 9 045 089 416 Bytes +171.3 KiB +0.002%
ydbd stripped size 489 466 536 Bytes 489 473 960 Bytes +7.2 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexvru alexvru force-pushed the vdisk/disable-blob-header-by-default branch 2 times, most recently from 143217b to c26b11d Compare September 23, 2024 10:23
@alexvru alexvru force-pushed the vdisk/disable-blob-header-by-default branch from c26b11d to a42833a Compare September 23, 2024 10:27
@github-actions
Copy link

github-actions bot commented Sep 23, 2024

2024-09-23 10:32:24 UTC Pre-commit check linux-x86_64-release-asan for f105907 has started.
2024-09-23 10:32:34 UTC Artifacts will be uploaded here
2024-09-23 10:35:37 UTC ya make is running...
🔴 2024-09-23 12:30:15 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11689 11485 0 52 40 112

🟢 2024-09-23 12:31:17 UTC Build successful.
🟢 2024-09-23 12:31:54 UTC ydbd size 5.6 GiB changed* by +5.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 7b2c0d2 merge: f105907 diff diff %
ydbd size 6 064 342 776 Bytes 6 064 348 176 Bytes +5.3 KiB +0.000%
ydbd stripped size 1 516 897 104 Bytes 1 516 900 880 Bytes +3.7 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 23, 2024

2024-09-23 10:36:35 UTC Pre-commit check linux-x86_64-relwithdebinfo for f105907 has started.
2024-09-23 10:36:45 UTC Artifacts will be uploaded here
2024-09-23 10:39:37 UTC ya make is running...
🟡 2024-09-23 11:47:55 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16337 14676 0 11 1606 44

2024-09-23 11:49:20 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-23 12:00:33 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
292 (only retried tests) 194 0 0 7 91

🟢 2024-09-23 12:00:40 UTC Build successful.
🟡 2024-09-23 12:01:19 UTC ydbd size 8.4 GiB changed* by +106.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: ae1b51a merge: f105907 diff diff %
ydbd size 9 046 511 176 Bytes 9 046 619 904 Bytes +106.2 KiB +0.001%
ydbd stripped size 489 505 576 Bytes 489 512 424 Bytes +6.7 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 23, 2024

2024-09-23 10:37:10 UTC Pre-commit check linux-x86_64-release-clang14 for f105907 has started.
2024-09-23 10:37:19 UTC Artifacts will be uploaded here
2024-09-23 10:40:18 UTC ya make is running...
🟢 2024-09-23 10:56:29 UTC Build successful.

@alexvru alexvru enabled auto-merge (squash) September 23, 2024 12:34
@alexvru alexvru merged commit e8e060a into ydb-platform:main Sep 23, 2024
@alexvru alexvru deleted the vdisk/disable-blob-header-by-default branch September 23, 2024 13:26
alexvru added a commit that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants