Skip to content

YQ WM fix for sls feature flag #7057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 30, 2024
Merged

YQ WM fix for sls feature flag #7057

merged 2 commits into from
Jul 30, 2024

Conversation

@GrigoriyPA
Copy link
Collaborator

@GrigoriyPA GrigoriyPA commented Jul 24, 2024 •
edited
Loading

Changelog entry

Fix for sls feature flag

Changelog category

  • Bugfix

Additional information
@GrigoriyPA GrigoriyPA requested a review from dorooleg July 24, 2024 17:44
@github-actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

⚪ 2024-07-24 17:47:30 UTC Pre-commit check for dc49907 has started.
⚪ 2024-07-24 17:50:42 UTC Check linux-x86_64-release-asan is running...
🔴 2024-07-24 19:48:51 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9635 9046 0 93 322 174

🟢 2024-07-24 19:50:44 UTC Build successful.
🟢 2024-07-24 19:51:36 UTC ydbd size 5.2 GiB changed* by +15.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: babf6c1 merge: dc49907 diff diff %
ydbd size 5 559 630 504 Bytes 5 559 645 848 Bytes +15.0 KiB +0.000%
ydbd stripped size 1 197 553 680 Bytes 1 197 557 200 Bytes +3.4 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
@github-actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

⚪ 2024-07-24 17:47:54 UTC Pre-commit check for dc49907 has started.
⚪ 2024-07-24 17:50:41 UTC Check linux-x86_64-relwithdebinfo is running...
🔴 2024-07-24 19:25:36 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13766 12425 0 4 1325 12

⚪ 2024-07-24 19:27:29 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🔴 2024-07-24 19:35:28 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14 (only retried tests) 5 0 1 0 8

⚪ 2024-07-24 19:37:40 UTC Failed tests rerun (try 3) linux-x86_64-relwithdebinfo is running...
🔴 2024-07-24 19:44:56 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10 (only retried tests) 1 0 1 0 8

🟢 2024-07-24 19:46:38 UTC Build successful.
🟡 2024-07-24 19:47:24 UTC ydbd size 8.1 GiB changed* by +964.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: ded90c7 merge: dc49907 diff diff %
ydbd size 8 658 083 760 Bytes 8 659 071 192 Bytes +964.3 KiB +0.011%
ydbd stripped size 471 273 792 Bytes 471 302 464 Bytes +28.0 KiB +0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
@github-actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

⚪ 2024-07-24 17:48:12 UTC Pre-commit check for dc49907 has started.
⚪ 2024-07-24 17:51:06 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-24 18:09:23 UTC Build successful.
@GrigoriyPA GrigoriyPA force-pushed the YQ-WM-fix-for-sls-feature-flag branch from 997711b to 2120c0c Compare July 29, 2024 07:14
@github-actions
Copy link

github-actions bot commented Jul 29, 2024 •
edited
Loading

⚪ 2024-07-29 07:17:44 UTC Pre-commit check for fc61207 has started.
⚪ 2024-07-29 07:20:35 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-29 07:25:37 UTC Build successful.
@github-actions
Copy link

github-actions bot commented Jul 29, 2024 •
edited
Loading

⚪ 2024-07-29 07:17:48 UTC Pre-commit check for fc61207 has started.
⚪ 2024-07-29 07:20:37 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-07-29 08:50:27 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13771 12425 0 6 1325 15

⚪ 2024-07-29 08:51:53 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟡 2024-07-29 09:00:02 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18 (only retried tests) 6 0 4 0 8

⚪ 2024-07-29 09:01:14 UTC Failed tests rerun (try 3) linux-x86_64-relwithdebinfo is running...
🔴 2024-07-29 09:08:34 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13 (only retried tests) 1 0 4 0 8

🟢 2024-07-29 09:09:44 UTC Build successful.
🟢 2024-07-29 09:10:23 UTC ydbd size 8.1 GiB changed* by +6.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 46db233 merge: fc61207 diff diff %
ydbd size 8 676 417 880 Bytes 8 676 424 400 Bytes +6.4 KiB +0.000%
ydbd stripped size 471 814 912 Bytes 471 815 232 Bytes +320 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
@github-actions
Copy link

github-actions bot commented Jul 29, 2024 •
edited
Loading

⚪ 2024-07-29 07:18:19 UTC Pre-commit check for fc61207 has started.
⚪ 2024-07-29 07:21:18 UTC Check linux-x86_64-release-asan is running...
🔴 2024-07-29 09:35:37 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9624 9026 0 97 329 172

🟢 2024-07-29 09:36:33 UTC Build successful.
🟢 2024-07-29 09:37:27 UTC ydbd size 5.2 GiB changed* by +6.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 46db233 merge: fc61207 diff diff %
ydbd size 5 569 854 496 Bytes 5 569 861 448 Bytes +6.8 KiB +0.000%
ydbd stripped size 1 199 036 752 Bytes 1 199 037 968 Bytes +1.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
dorooleg
dorooleg previously approved these changes Jul 30, 2024
View reviewed changes
@GrigoriyPA GrigoriyPA force-pushed the YQ-WM-fix-for-sls-feature-flag branch from 2120c0c to bbff978 Compare July 30, 2024 08:48
@github-actions
Copy link

github-actions bot commented Jul 30, 2024 •
edited
Loading

⚪ 2024-07-30 08:51:59 UTC Pre-commit check for cef1393 has started.
⚪ 2024-07-30 08:54:53 UTC Check linux-x86_64-release-clang14 is running...
⚫ 2024-07-30 09:00:46 UTC Check cancelled
@github-actions
Copy link

github-actions bot commented Jul 30, 2024 •
edited
Loading

⚪ 2024-07-30 08:52:19 UTC Pre-commit check for cef1393 has started.
⚪ 2024-07-30 08:55:08 UTC Check linux-x86_64-relwithdebinfo is running...
⚫ 2024-07-30 09:01:08 UTC Check cancelled
@github-actions
Copy link

github-actions bot commented Jul 30, 2024 •
edited
Loading

⚪ 2024-07-30 08:52:23 UTC Pre-commit check for cef1393 has started.
⚪ 2024-07-30 08:55:15 UTC Check linux-x86_64-release-asan is running...
⚫ 2024-07-30 09:00:41 UTC Check cancelled
@github-actions
Copy link

github-actions bot commented Jul 30, 2024 •
edited
Loading

⚪ 2024-07-30 09:03:00 UTC Pre-commit check for 03452d3 has started.
⚪ 2024-07-30 09:06:13 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-30 09:12:48 UTC Build successful.
@github-actions
Copy link

github-actions bot commented Jul 30, 2024 •
edited
Loading

⚪ 2024-07-30 09:05:42 UTC Pre-commit check for 03452d3 has started.
⚪ 2024-07-30 09:08:38 UTC Check linux-x86_64-release-asan is running...
🔴 2024-07-30 11:24:42 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9624 9035 0 86 326 177

🟢 2024-07-30 11:25:43 UTC Build successful.
🟡 2024-07-30 11:26:41 UTC ydbd size 5.2 GiB changed* by +276.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: a544002 merge: 03452d3 diff diff %
ydbd size 5 571 106 936 Bytes 5 571 389 808 Bytes +276.2 KiB +0.005%
ydbd stripped size 1 199 206 384 Bytes 1 199 270 992 Bytes +63.1 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
@github-actions
Copy link

github-actions bot commented Jul 30, 2024 •
edited
Loading

⚪ 2024-07-30 09:06:11 UTC Pre-commit check for 03452d3 has started.
⚪ 2024-07-30 09:09:06 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-07-30 10:41:29 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13772 12428 0 5 1328 11

⚪ 2024-07-30 10:42:52 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-07-30 10:51:17 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12 (only retried tests) 4 0 0 0 8

🟢 2024-07-30 10:52:26 UTC Build successful.
🟡 2024-07-30 10:52:58 UTC ydbd size 8.1 GiB changed* by +429.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: a544002 merge: 03452d3 diff diff %
ydbd size 8 678 664 848 Bytes 8 679 104 864 Bytes +429.7 KiB +0.005%
ydbd stripped size 471 871 840 Bytes 471 893 280 Bytes +20.9 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
@GrigoriyPA GrigoriyPA requested a review from dorooleg July 30, 2024 09:35
@GrigoriyPA GrigoriyPA merged commit 9d12242 into ydb-platform:main Jul 30, 2024
@GrigoriyPA GrigoriyPA deleted the YQ-WM-fix-for-sls-feature-flag branch July 30, 2024 11:30
GrigoriyPA added a commit to GrigoriyPA/ydb that referenced this pull request Jul 30, 2024
@GrigoriyPA
YQ WM fix for sls feature flag (ydb-platform#7057)
c2fb3fa
@GrigoriyPA GrigoriyPA mentioned this pull request Jul 30, 2024
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Aug 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix

2 participants

@GrigoriyPA @dorooleg