Skip to content

Conversation

@CyberROFL
Copy link
Member

@CyberROFL CyberROFL commented May 27, 2025

Merge from main:

Fix crash when selecting split key from key access sample containing entries of different sizes. Size differences could occur when exact key accesses are mixed with key prefix operations (such as range reads). But the key comparator used was asymmetrical, allowing comparison of full keys to prefixes but not vice versa.

fix #13991

Changelog entry

Table auto partitioning: Fixed crash when selecting split key from access samples containing a mix of full key and key prefix operations (e.g. exact/range reads).

Changelog category

  • Bugfix
…#18201) Fix crash when selecting split key from key access sample containing entries of different sizes. Size differences could occur when exact key accesses are mixed with key prefix operations (such as range reads). But the key comparator used was asymmetrical, allowing comparison of full keys to prefixes but not vice versa. fix ydb-platform#13991
@CyberROFL CyberROFL self-assigned this May 27, 2025
@CyberROFL CyberROFL marked this pull request as ready for review May 27, 2025 11:04
@CyberROFL CyberROFL requested a review from a team as a code owner May 27, 2025 11:04
@github-actions
Copy link

github-actions bot commented May 27, 2025

2025-05-27 11:04:36 UTC Pre-commit check linux-x86_64-release-asan for 433550e has started.
2025-05-27 11:04:49 UTC Check cancelled

@CyberROFL CyberROFL added the area/schemeshard Issues related to Scheme Shard system tablet label May 27, 2025
@github-actions
Copy link

github-actions bot commented May 27, 2025

2025-05-27 11:04:36 UTC Pre-commit check linux-x86_64-relwithdebinfo for 433550e has started.
2025-05-27 11:04:49 UTC Check cancelled

@CyberROFL CyberROFL linked an issue May 27, 2025 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented May 27, 2025

2025-05-27 11:08:26 UTC Pre-commit check linux-x86_64-relwithdebinfo for 433550e has started.
2025-05-27 11:08:38 UTC Artifacts will be uploaded here
2025-05-27 11:11:43 UTC ya make is running...
🟡 2025-05-27 12:13:33 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18951 17673 0 5 1207 66

2025-05-27 12:15:06 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-05-27 12:36:00 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
133 (only retried tests) 71 0 0 1 61

🟢 2025-05-27 12:36:07 UTC Build successful.
🟢 2025-05-27 12:36:28 UTC ydbd size 2.1 GiB changed* by -512 Bytes, which is <= 0 Bytes vs stable-25-1-1: OK

ydbd size dash stable-25-1-1: f9fc96c merge: 433550e diff diff %
ydbd size 2 243 579 512 Bytes 2 243 579 000 Bytes -512 Bytes -0.000%
ydbd stripped size 475 086 840 Bytes 475 087 160 Bytes +320 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented May 27, 2025

2025-05-27 11:09:02 UTC Pre-commit check linux-x86_64-release-asan for 433550e has started.
2025-05-27 11:09:13 UTC Artifacts will be uploaded here
2025-05-27 11:12:10 UTC ya make is running...
🟡 2025-05-27 12:25:23 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11841 11726 0 76 4 35

2025-05-27 12:26:26 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-27 12:47:21 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
160 (only retried tests) 127 0 1 1 31

2025-05-27 12:47:29 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-27 13:07:48 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
58 (only retried tests) 26 0 1 0 31

🟢 2025-05-27 13:07:55 UTC Build successful.
🟢 2025-05-27 13:08:23 UTC ydbd size 3.6 GiB changed* by +4.3 KiB, which is < 100.0 KiB vs stable-25-1-1: OK

ydbd size dash stable-25-1-1: f9fc96c merge: 433550e diff diff %
ydbd size 3 902 738 392 Bytes 3 902 742 808 Bytes +4.3 KiB +0.000%
ydbd stripped size 1 365 704 496 Bytes 1 365 706 992 Bytes +2.4 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@CyberROFL CyberROFL merged commit 319908d into ydb-platform:stable-25-1-1 May 27, 2025
14 of 18 checks passed
@CyberROFL CyberROFL deleted the schemeshard-histogram-keys-comparison-25-1-1 branch May 27, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/schemeshard Issues related to Scheme Shard system tablet

3 participants