Skip to content

Conversation

@ijon
Copy link
Collaborator

@ijon ijon commented May 15, 2025

Merge from main:

Fix crash when selecting split key from key access sample containing entries of different sizes. Size differences could occur when exact key accesses are mixed with key prefix operations (such as range reads). But the key comparator used was asymmetrical, allowing comparison of full keys to prefixes but not vice versa.

fix #13991

Changelog entry

Table auto partitioning: Fixed crash when selecting split key from access samples containing a mix of full key and key prefix operations (e.g. exact/range reads).

Changelog category

  • Bugfix
…#18201) Fix crash when selecting split key from key access sample containing entries of different sizes. Size differences could occur when exact key accesses are mixed with key prefix operations (such as range reads). But the key comparator used was asymmetrical, allowing comparison of full keys to prefixes but not vice versa. fix ydb-platform#13991
@ijon ijon requested a review from a team as a code owner May 15, 2025 12:02
@ijon ijon linked an issue May 15, 2025 that may be closed by this pull request
@ijon ijon added area/schemeshard Issues related to Scheme Shard system tablet bug/crash ydbd process crashed labels May 15, 2025
@ijon ijon changed the title 25:1 schemeshard: fix split key selection from access sample 25-1: schemeshard: fix split key selection from access sample May 15, 2025
@github-actions
Copy link

github-actions bot commented May 15, 2025

2025-05-15 12:11:03 UTC Pre-commit check linux-x86_64-release-asan for 50805ca has started.
2025-05-15 12:11:11 UTC Artifacts will be uploaded here
2025-05-15 12:14:05 UTC ya make is running...
🟡 2025-05-15 13:28:35 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12150 11956 0 99 57 38

2025-05-15 13:29:49 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-15 13:50:35 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
246 (only retried tests) 158 0 7 46 35

2025-05-15 13:50:44 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-15 14:10:35 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
118 (only retried tests) 32 0 7 43 36

🟢 2025-05-15 14:10:44 UTC Build successful.
🟢 2025-05-15 14:11:15 UTC ydbd size 3.6 GiB changed* by +44.1 KiB, which is < 100.0 KiB vs stable-25-1: OK

ydbd size dash stable-25-1: a3e836e merge: 50805ca diff diff %
ydbd size 3 912 498 160 Bytes 3 912 543 368 Bytes +44.1 KiB +0.001%
ydbd stripped size 1 368 422 768 Bytes 1 368 442 416 Bytes +19.2 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented May 15, 2025

🟢 2025-05-15 12:13:54 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented May 15, 2025

2025-05-15 12:53:28 UTC Pre-commit check linux-x86_64-relwithdebinfo for 50805ca has started.
2025-05-15 12:54:23 UTC Artifacts will be uploaded here
2025-05-15 12:57:46 UTC ya make is running...
🟡 2025-05-15 13:55:54 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19197 17922 0 3 1213 59

2025-05-15 13:57:36 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-05-15 14:18:48 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
125 (only retried tests) 67 0 0 0 58

🟢 2025-05-15 14:19:00 UTC Build successful.
🟡 2025-05-15 14:19:17 UTC ydbd size 2.1 GiB changed* by +113.0 KiB, which is >= 100.0 KiB vs stable-25-1: Warning

ydbd size dash stable-25-1: 7a9a4c6 merge: 50805ca diff diff %
ydbd size 2 249 014 112 Bytes 2 249 129 864 Bytes +113.0 KiB +0.005%
ydbd stripped size 475 964 920 Bytes 475 988 120 Bytes +22.7 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ijon ijon merged commit 3deaccb into ydb-platform:stable-25-1 May 16, 2025
21 of 28 checks passed
@ijon ijon deleted the merge/25-1/schemeshard-histogram-keys-comparison branch June 9, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/schemeshard Issues related to Scheme Shard system tablet bug/crash ydbd process crashed

2 participants