Skip to content

Limit inflight config updates #17725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 25, 2025
Merged

Limit inflight config updates #17725

merged 3 commits into from
Apr 25, 2025

Conversation

@CyberROFL
Copy link
Member

@CyberROFL CyberROFL commented Apr 25, 2025 •
edited
Loading

Changelog entry

Limit internal inflight config updates.

Changelog category

  • Performance improvement

Description for reviewers

...
@github-actions
Copy link

github-actions bot commented Apr 25, 2025 •
edited
Loading

🟢 2025-04-25 10:49:38 UTC The validation of the Pull Request description is successful.
@CyberROFL CyberROFL linked an issue Apr 25, 2025 that may be closed by this pull request
ConfigProvider: limit inflight config updates #17722
Closed
@CyberROFL CyberROFL marked this pull request as ready for review April 25, 2025 10:43
@CyberROFL CyberROFL requested a review from a team as a code owner April 25, 2025 10:43
@CyberROFL CyberROFL requested a review from Enjection April 25, 2025 10:43
@CyberROFL CyberROFL requested review from pixcc and snaury and removed request for Enjection April 25, 2025 10:46
@github-actions
Copy link

github-actions bot commented Apr 25, 2025 •
edited
Loading

⚪ 2025-04-25 10:50:17 UTC Pre-commit check linux-x86_64-relwithdebinfo for 76158c1 has started.
⚪ 2025-04-25 10:50:31 UTC Artifacts will be uploaded here
⚪ 2025-04-25 10:53:12 UTC ya make is running...
🟡 2025-04-25 12:36:03 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20172 18788 0 1 1345 38

⚪ 2025-04-25 12:37:43 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-04-25 12:49:48 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
93 (only retried tests) 67 0 0 0 26

🟢 2025-04-25 12:49:55 UTC Build successful.
🟢 2025-04-25 12:50:14 UTC ydbd size 2.2 GiB changed* by +38.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 6e24151 merge: 76158c1 diff diff %
ydbd size 2 354 794 104 Bytes 2 354 833 488 Bytes +38.5 KiB +0.002%
ydbd stripped size 494 254 848 Bytes 494 263 424 Bytes +8.4 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
@github-actions
Copy link

github-actions bot commented Apr 25, 2025 •
edited
Loading

⚪ 2025-04-25 10:51:21 UTC Pre-commit check linux-x86_64-release-asan for 76158c1 has started.
⚪ 2025-04-25 10:51:49 UTC Artifacts will be uploaded here
⚪ 2025-04-25 10:55:11 UTC ya make is running...
🟡 2025-04-25 12:48:41 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12638 12483 0 88 45 22

⚪ 2025-04-25 12:49:50 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-25 13:03:28 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
193 (only retried tests) 106 0 39 24 24

⚪ 2025-04-25 13:03:37 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-25 13:16:00 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
109 (only retried tests) 51 0 33 3 22

🟢 2025-04-25 13:16:09 UTC Build successful.
🟢 2025-04-25 13:16:43 UTC ydbd size 3.9 GiB changed* by +61.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: d7c0986 merge: 76158c1 diff diff %
ydbd size 4 136 732 624 Bytes 4 136 795 528 Bytes +61.4 KiB +0.002%
ydbd stripped size 1 432 102 872 Bytes 1 432 128 696 Bytes +25.2 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
snaury
snaury previously approved these changes Apr 25, 2025
View reviewed changes
pixcc
pixcc reviewed Apr 25, 2025
View reviewed changes
snaury
snaury previously approved these changes Apr 25, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Apr 25, 2025 •
edited
Loading

⚪ 2025-04-25 14:32:11 UTC Pre-commit check linux-x86_64-release-asan for 3e61386 has started.
⚪ 2025-04-25 14:32:27 UTC Artifacts will be uploaded here
⚪ 2025-04-25 14:35:19 UTC ya make is running...
⚫ 2025-04-25 14:42:33 UTC Check cancelled
pixcc
pixcc previously approved these changes Apr 25, 2025
View reviewed changes
@CyberROFL CyberROFL dismissed stale reviews from pixcc and snaury via 5ec9a0f April 25, 2025 14:42
@github-actions
Copy link

github-actions bot commented Apr 25, 2025 •
edited
Loading

⚪ 2025-04-25 14:43:13 UTC Pre-commit check linux-x86_64-release-asan for 87f39dd has started.
⚪ 2025-04-25 14:43:36 UTC Artifacts will be uploaded here
⚪ 2025-04-25 14:46:58 UTC ya make is running...
🟡 2025-04-25 16:02:19 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12654 12487 0 94 49 24

⚪ 2025-04-25 16:03:23 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-25 16:16:38 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
195 (only retried tests) 132 0 38 3 22

⚪ 2025-04-25 16:16:47 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-25 16:28:56 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
87 (only retried tests) 30 0 34 1 22

🟢 2025-04-25 16:29:03 UTC Build successful.
🟡 2025-04-25 16:29:33 UTC ydbd size 3.8 GiB changed* by +110.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 48459a5 merge: 87f39dd diff diff %
ydbd size 4 120 128 952 Bytes 4 120 242 032 Bytes +110.4 KiB +0.003%
ydbd stripped size 1 428 472 952 Bytes 1 428 517 080 Bytes +43.1 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
@CyberROFL CyberROFL enabled auto-merge (squash) April 25, 2025 14:57
@github-actions
Copy link

github-actions bot commented Apr 25, 2025 •
edited
Loading

⚪ 2025-04-25 15:46:11 UTC Pre-commit check linux-x86_64-relwithdebinfo for 87f39dd has started.
⚪ 2025-04-25 15:46:37 UTC Artifacts will be uploaded here
⚪ 2025-04-25 15:50:10 UTC ya make is running...
🟡 2025-04-25 17:04:33 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20188 18810 0 8 1330 40

⚪ 2025-04-25 17:06:17 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-04-25 17:21:04 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
88 (only retried tests) 59 0 0 0 29

🟢 2025-04-25 17:21:13 UTC Build successful.
🟢 2025-04-25 17:21:36 UTC ydbd size 2.2 GiB changed* by +64.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 91f69c4 merge: 87f39dd diff diff %
ydbd size 2 342 094 976 Bytes 2 342 160 656 Bytes +64.1 KiB +0.003%
ydbd stripped size 492 572 032 Bytes 492 585 408 Bytes +13.1 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
@CyberROFL CyberROFL merged commit f930039 into ydb-platform:main Apr 25, 2025
15 checks passed
@CyberROFL CyberROFL deleted the limit-inflight-config-updates branch April 25, 2025 19:14
CyberROFL added a commit to CyberROFL/ydb that referenced this pull request Apr 25, 2025
@CyberROFL
Limit inflight config updates (ydb-platform#17725)
32b7e60
CyberROFL added a commit to CyberROFL/ydb that referenced this pull request Apr 25, 2025
@CyberROFL
Limit inflight config updates (ydb-platform#17725)
6bb55ac
CyberROFL added a commit to CyberROFL/ydb that referenced this pull request Apr 25, 2025
@CyberROFL
Limit inflight config updates (ydb-platform#17725)
5512e54
This was referenced Apr 25, 2025
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance

3 participants

@CyberROFL @snaury @pixcc