Skip to content

Fix optional columns handling in read_rows rpc #15850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2025
Merged

Fix optional columns handling in read_rows rpc #15850

merged 1 commit into from
Apr 1, 2025

Conversation

@lex007in
Copy link
Collaborator

@lex007in lex007in commented Mar 17, 2025 •
edited
Loading

Changelog entry

Fix optional columns handling in read_rows rpc #15701

Changelog category

  • Bugfix

Description for reviewers

...
@github-actions
Copy link

github-actions bot commented Mar 17, 2025 •
edited
Loading

⚪ 2025-03-17 15:58:53 UTC Pre-commit check linux-x86_64-relwithdebinfo for e68dbd9 has started.
⚪ 2025-03-17 15:59:09 UTC Artifacts will be uploaded here
⚪ 2025-03-17 16:02:05 UTC ya make is running...
🟡 2025-03-17 16:54:40 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19531 18157 0 23 1230 121

⚪ 2025-03-17 16:56:45 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-17 17:14:41 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
217 (only retried tests) 86 0 16 4 111

⚪ 2025-03-17 17:14:52 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-03-17 17:26:45 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
191 (only retried tests) 62 0 16 2 111

🟢 2025-03-17 17:26:52 UTC Build successful.
🟢 2025-03-17 17:27:15 UTC ydbd size 2.1 GiB changed* by +2.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 72b229f merge: e68dbd9 diff diff %
ydbd size 2 298 537 064 Bytes 2 298 539 400 Bytes +2.3 KiB +0.000%
ydbd stripped size 481 147 776 Bytes 481 148 480 Bytes +704 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
@github-actions
Copy link

github-actions bot commented Mar 17, 2025 •
edited
Loading

⚪ 2025-03-17 15:58:55 UTC Pre-commit check linux-x86_64-release-asan for e68dbd9 has started.
⚪ 2025-03-17 15:59:10 UTC Artifacts will be uploaded here
⚪ 2025-03-17 16:02:03 UTC ya make is running...
🟡 2025-03-17 17:08:23 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12035 11923 0 58 15 39

⚪ 2025-03-17 17:09:32 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-17 17:27:40 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
182 (only retried tests) 124 0 16 5 37

⚪ 2025-03-17 17:27:53 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-17 17:40:41 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
104 (only retried tests) 49 0 16 3 36

🟢 2025-03-17 17:40:50 UTC Build successful.
🟢 2025-03-17 17:41:21 UTC ydbd size 3.8 GiB changed* by +7.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 72b229f merge: e68dbd9 diff diff %
ydbd size 4 047 153 736 Bytes 4 047 161 016 Bytes +7.1 KiB +0.000%
ydbd stripped size 1 400 230 024 Bytes 1 400 234 120 Bytes +4.0 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
@github-actions
Copy link

github-actions bot commented Mar 17, 2025 •
edited
Loading

🟢 2025-03-27 22:56:12 UTC The validation of the Pull Request description is successful.
@github-actions github-actions bot added bugfix and removed bugfix labels Mar 17, 2025
@github-actions
Copy link

github-actions bot commented Mar 27, 2025 •
edited
Loading

⚪ 2025-03-27 19:23:53 UTC Pre-commit check linux-x86_64-release-asan for 65ac4f9 has started.
⚪ 2025-03-27 19:24:20 UTC Artifacts will be uploaded here
⚪ 2025-03-27 19:27:42 UTC ya make is running...
⚫ 2025-03-27 19:55:41 UTC Check cancelled
@github-actions
Copy link

github-actions bot commented Mar 27, 2025 •
edited
Loading

⚪ 2025-03-27 19:26:08 UTC Pre-commit check linux-x86_64-relwithdebinfo for 65ac4f9 has started.
⚪ 2025-03-27 19:26:28 UTC Artifacts will be uploaded here
⚪ 2025-03-27 19:29:10 UTC ya make is running...
⚫ 2025-03-27 19:55:42 UTC Check cancelled
@github-actions
Copy link

github-actions bot commented Mar 27, 2025 •
edited
Loading

⚪ 2025-03-27 19:58:16 UTC Pre-commit check linux-x86_64-relwithdebinfo for 219df53 has started.
⚪ 2025-03-27 19:59:06 UTC Artifacts will be uploaded here
⚪ 2025-03-27 20:02:37 UTC ya make is running...
🟡 2025-03-27 21:02:20 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19724 18354 0 4 1252 114

⚪ 2025-03-27 21:04:00 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-27 21:18:34 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
175 (only retried tests) 75 0 0 0 100

🟢 2025-03-27 21:18:43 UTC Build successful.
🟢 2025-03-27 21:19:04 UTC ydbd size 2.2 GiB changed* by +12.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 5f9dbe8 merge: 219df53 diff diff %
ydbd size 2 344 386 520 Bytes 2 344 399 552 Bytes +12.7 KiB +0.001%
ydbd stripped size 490 252 992 Bytes 490 255 872 Bytes +2.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
@github-actions
Copy link

github-actions bot commented Mar 27, 2025 •
edited
Loading

⚪ 2025-03-27 19:59:49 UTC Pre-commit check linux-x86_64-release-asan for 219df53 has started.
⚪ 2025-03-27 20:00:04 UTC Artifacts will be uploaded here
⚪ 2025-03-27 20:02:54 UTC ya make is running...
🟡 2025-03-27 21:19:10 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12182 12057 0 77 10 38

⚪ 2025-03-27 21:20:19 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-27 21:35:09 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
183 (only retried tests) 141 0 4 6 32

⚪ 2025-03-27 21:35:21 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-27 21:49:01 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67 (only retried tests) 29 0 3 4 31

🟢 2025-03-27 21:49:07 UTC Build successful.
🟢 2025-03-27 21:49:35 UTC ydbd size 3.8 GiB changed* by +10.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 4a35432 merge: 219df53 diff diff %
ydbd size 4 113 860 072 Bytes 4 113 870 328 Bytes +10.0 KiB +0.000%
ydbd stripped size 1 421 614 248 Bytes 1 421 618 664 Bytes +4.3 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
@lex007in lex007in changed the title Fix optional columns handling in rpc Fix optional columns handling in read_rows rpc Mar 27, 2025
@github-actions github-actions bot added bugfix and removed bugfix labels Mar 27, 2025
@lex007in lex007in linked an issue Mar 27, 2025 that may be closed by this pull request
bug: ReadRows kills ydb-local #15701
Closed
@github-actions github-actions bot added bugfix and removed bugfix labels Mar 27, 2025
@lex007in lex007in marked this pull request as ready for review March 27, 2025 22:57
@lex007in lex007in requested a review from a team as a code owner March 27, 2025 22:57
@lex007in lex007in merged commit 04d730d into ydb-platform:main Apr 1, 2025
18 of 20 checks passed
@lex007in lex007in deleted the optional_in_rpc branch April 1, 2025 14:23
lex007in added a commit to lex007in/ydb that referenced this pull request Apr 4, 2025
@lex007in
Fix optional columns handling in read_rows rpc (ydb-platform#15850)
df027ac
@lex007in lex007in mentioned this pull request Apr 4, 2025
Merged
lex007in added a commit that referenced this pull request Apr 7, 2025
@lex007in
25-1: ReadTable and ReadRows RPC fixes (#15721, #15850) (#16799)
8be911b
lex007in added a commit to lex007in/ydb that referenced this pull request Apr 17, 2025
@lex007in
Fix optional columns handling in read_rows rpc (ydb-platform#15850)
ca334aa
@lex007in lex007in mentioned this pull request Apr 17, 2025
Merged
lex007in added a commit to lex007in/ydb that referenced this pull request Apr 17, 2025
@lex007in
Fix optional columns handling in read_rows rpc (ydb-platform#15850)
4830523
lex007in added a commit that referenced this pull request Apr 18, 2025
@lex007in
24-4: ReadTable and ReadRows RPC fixes (#15721, #15850) (#17332)
5537495
lex007in added a commit to lex007in/ydb that referenced this pull request May 19, 2025
@lex007in
Fix optional columns handling in read_rows rpc (ydb-platform#15850)
5fecf7d
@lex007in lex007in mentioned this pull request May 19, 2025
Merged
lex007in added a commit to lex007in/ydb that referenced this pull request May 19, 2025
@lex007in
Fix optional columns handling in read_rows rpc (ydb-platform#15850)
4b32fb7
@lex007in lex007in mentioned this pull request May 19, 2025
Merged
lex007in added a commit that referenced this pull request May 20, 2025
@lex007in
24-4-4-hotfix: ReadTable and ReadRows RPC fixes (#15721, #15850) (#18506
d5b3397 
)
lex007in added a commit that referenced this pull request May 20, 2025
@lex007in
25-1-1: ReadTable and ReadRows RPC fixes (#15721, #15850) (#18507)
d5f10c3
dcherednik pushed a commit to dcherednik/ydb that referenced this pull request Jun 2, 2025
@lex007in @dcherednik
Fix optional columns handling in read_rows rpc (ydb-platform#15850)
df763e2
@dcherednik dcherednik mentioned this pull request Jun 2, 2025
Merged
dcherednik added a commit that referenced this pull request Jun 3, 2025
@dcherednik @lex007in
Fix optional columns handling in read_rows rpc (#15850) (#19197)
54b3d44 
Co-authored-by: Ivan Nikolaev <ivannik@ydb.tech>
This was referenced Jun 3, 2025
Closed
Closed
@StekPerepolnen StekPerepolnen mentioned this pull request Aug 5, 2025
Closed
@StekPerepolnen StekPerepolnen mentioned this pull request Sep 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix

3 participants

@lex007in @snaury @gridnevvvit