Skip to content

Finish implementing shred logic in VDisk #14534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 14, 2025
Merged

Finish implementing shred logic in VDisk #14534

merged 1 commit into from
Feb 14, 2025

Conversation

@alexvru
Copy link
Collaborator

@alexvru alexvru commented Feb 13, 2025

Changelog entry

Finish implementing shred logic in VDisk

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

VDisk now finally supports shredding (except for forceful synclog shredding).
@github-actions
Copy link

github-actions bot commented Feb 13, 2025 •
edited
Loading

⚪ 2025-02-13 13:38:32 UTC Pre-commit check linux-x86_64-relwithdebinfo for d6372c2 has started.
⚪ 2025-02-13 13:38:51 UTC Artifacts will be uploaded here
⚪ 2025-02-13 13:42:31 UTC ya make is running...
🟡 2025-02-13 15:08:19 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27838 25224 0 21 2459 134

⚪ 2025-02-13 15:11:40 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-13 15:25:03 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
245 (only retried tests) 97 0 19 3 126

⚪ 2025-02-13 15:25:20 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-02-13 15:51:35 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
225 (only retried tests) 81 0 18 0 126

🟢 2025-02-13 15:51:45 UTC Build successful.
🟡 2025-02-13 15:52:09 UTC ydbd size 2.1 GiB changed* by +260.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 47bf59d merge: d6372c2 diff diff %
ydbd size 2 230 178 888 Bytes 2 230 445 912 Bytes +260.8 KiB +0.012%
ydbd stripped size 473 431 544 Bytes 473 481 528 Bytes +48.8 KiB +0.011%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
@github-actions
Copy link

github-actions bot commented Feb 13, 2025 •
edited
Loading

⚪ 2025-02-13 13:39:28 UTC Pre-commit check linux-x86_64-release-asan for d6372c2 has started.
⚪ 2025-02-13 13:39:42 UTC Artifacts will be uploaded here
⚪ 2025-02-13 13:42:49 UTC ya make is running...
🟡 2025-02-13 15:06:53 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13670 13589 0 24 20 37

⚪ 2025-02-13 15:08:18 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-13 15:26:31 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
116 (only retried tests) 79 0 2 3 32

⚪ 2025-02-13 15:26:42 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-02-13 15:38:19 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
64 (only retried tests) 29 0 2 4 29

🟢 2025-02-13 15:38:27 UTC Build successful.
🟡 2025-02-13 15:38:58 UTC ydbd size 3.6 GiB changed* by +434.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 47bf59d merge: d6372c2 diff diff %
ydbd size 3 878 588 336 Bytes 3 879 033 608 Bytes +434.8 KiB +0.011%
ydbd stripped size 1 358 284 480 Bytes 1 358 413 760 Bytes +126.2 KiB +0.010%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
@github-actions
Copy link

github-actions bot commented Feb 13, 2025 •
edited
Loading

⚪ 2025-02-13 17:10:45 UTC Pre-commit check linux-x86_64-relwithdebinfo for f2e33a1 has started.
⚪ 2025-02-13 17:11:38 UTC Artifacts will be uploaded here
⚫ 2025-02-13 17:12:09 UTC Check cancelled
@github-actions
Copy link

github-actions bot commented Feb 13, 2025 •
edited
Loading

⚪ 2025-02-13 17:13:48 UTC Pre-commit check linux-x86_64-relwithdebinfo for 12cdabb has started.
⚪ 2025-02-13 17:14:16 UTC Artifacts will be uploaded here
⚪ 2025-02-13 17:17:21 UTC ya make is running...
⚫ 2025-02-13 17:19:01 UTC Check cancelled
@github-actions
Copy link

github-actions bot commented Feb 13, 2025 •
edited
Loading

⚪ 2025-02-13 17:16:18 UTC Pre-commit check linux-x86_64-release-asan for 12cdabb has started.
⚪ 2025-02-13 17:17:22 UTC Artifacts will be uploaded here
⚫ 2025-02-13 17:18:58 UTC Check cancelled
@github-actions
Copy link

github-actions bot commented Feb 13, 2025 •
edited
Loading

⚪ 2025-02-13 17:21:03 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8e67bfc has started.
⚪ 2025-02-13 17:21:09 UTC Artifacts will be uploaded here
⚪ 2025-02-13 17:24:15 UTC ya make is running...
⚫ 2025-02-13 18:17:21 UTC Check cancelled
@github-actions
Copy link

github-actions bot commented Feb 13, 2025 •
edited
Loading

⚪ 2025-02-13 17:22:34 UTC Pre-commit check linux-x86_64-release-asan for 8e67bfc has started.
⚪ 2025-02-13 17:23:06 UTC Artifacts will be uploaded here
⚪ 2025-02-13 17:26:48 UTC ya make is running...
⚫ 2025-02-13 18:17:20 UTC Check cancelled
@github-actions
Copy link

github-actions bot commented Feb 13, 2025 •
edited
Loading

⚪ 2025-02-13 18:22:50 UTC Pre-commit check linux-x86_64-relwithdebinfo for bfe41d2 has started.
⚪ 2025-02-13 18:24:20 UTC Artifacts will be uploaded here
⚪ 2025-02-13 18:28:24 UTC ya make is running...
🔴 2025-02-13 18:32:03 UTC Build failed, see the logs. Also see fail summary
@github-actions
Copy link

github-actions bot commented Feb 13, 2025 •
edited
Loading

⚪ 2025-02-13 18:23:35 UTC Pre-commit check linux-x86_64-release-asan for bfe41d2 has started.
⚪ 2025-02-13 18:24:06 UTC Artifacts will be uploaded here
⚪ 2025-02-13 18:27:44 UTC ya make is running...
⚫ 2025-02-13 18:38:47 UTC Check cancelled
@github-actions
Copy link

github-actions bot commented Feb 13, 2025 •
edited
Loading

⚪ 2025-02-13 18:41:32 UTC Pre-commit check linux-x86_64-relwithdebinfo for d420ea6 has started.
⚪ 2025-02-13 18:45:27 UTC Artifacts will be uploaded here
⚪ 2025-02-13 18:48:30 UTC ya make is running...
🔴 2025-02-13 18:53:35 UTC Build failed, see the logs. Also see fail summary
@github-actions
Copy link

github-actions bot commented Feb 13, 2025 •
edited
Loading

⚪ 2025-02-13 18:48:56 UTC Pre-commit check linux-x86_64-release-asan for d420ea6 has started.
⚪ 2025-02-13 18:50:37 UTC Artifacts will be uploaded here
⚪ 2025-02-13 18:53:39 UTC ya make is running...
🔴 2025-02-13 18:57:02 UTC Build failed, see the logs. Also see fail summary
@github-actions
Copy link

github-actions bot commented Feb 13, 2025 •
edited
Loading

⚪ 2025-02-13 19:43:05 UTC Pre-commit check linux-x86_64-relwithdebinfo for f61522f has started.
⚪ 2025-02-13 19:43:17 UTC Artifacts will be uploaded here
⚪ 2025-02-13 19:46:21 UTC ya make is running...
🟡 2025-02-13 21:11:29 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27848 25240 0 21 2455 132

⚪ 2025-02-13 21:13:46 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-13 21:26:08 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
237 (only retried tests) 87 0 21 1 128

⚪ 2025-02-13 21:26:21 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-02-13 21:43:55 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
230 (only retried tests) 81 0 21 0 128

🟢 2025-02-13 21:44:02 UTC Build successful.
🟡 2025-02-13 21:44:26 UTC ydbd size 2.1 GiB changed* by +358.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 28180f6 merge: f61522f diff diff %
ydbd size 2 232 662 400 Bytes 2 233 029 640 Bytes +358.6 KiB +0.016%
ydbd stripped size 473 850 552 Bytes 473 926 072 Bytes +73.8 KiB +0.016%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
@github-actions
Copy link

github-actions bot commented Feb 13, 2025 •
edited
Loading

⚪ 2025-02-13 19:43:18 UTC Pre-commit check linux-x86_64-release-asan for f61522f has started.
⚪ 2025-02-13 19:43:31 UTC Artifacts will be uploaded here
⚪ 2025-02-13 19:46:43 UTC ya make is running...
🟡 2025-02-13 21:19:05 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13671 13580 0 34 22 35

⚪ 2025-02-13 21:20:24 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-13 21:32:49 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
136 (only retried tests) 94 0 2 5 35

⚪ 2025-02-13 21:32:58 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-02-13 21:50:20 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
71 (only retried tests) 34 0 2 4 31

🟢 2025-02-13 21:50:27 UTC Build successful.
🟡 2025-02-13 21:50:57 UTC ydbd size 3.6 GiB changed* by +619.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 28180f6 merge: f61522f diff diff %
ydbd size 3 882 848 808 Bytes 3 883 482 816 Bytes +619.1 KiB +0.016%
ydbd stripped size 1 359 665 552 Bytes 1 359 859 280 Bytes +189.2 KiB +0.014%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
@github-actions
Copy link

github-actions bot commented Feb 14, 2025 •
edited
Loading

⚪ 2025-02-14 06:54:02 UTC Pre-commit check linux-x86_64-relwithdebinfo for a7a8833 has started.
⚪ 2025-02-14 06:54:10 UTC Artifacts will be uploaded here
⚪ 2025-02-14 06:57:23 UTC ya make is running...
🟡 2025-02-14 08:26:20 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27848 25233 0 8 2469 138

⚪ 2025-02-14 08:28:55 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-14 08:33:05 UTC ydbd size 2.1 GiB changed* by +358.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 02ee311 merge: a7a8833 diff diff %
ydbd size 2 233 189 520 Bytes 2 233 556 760 Bytes +358.6 KiB +0.016%
ydbd stripped size 473 938 616 Bytes 474 014 136 Bytes +73.8 KiB +0.016%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2025-02-14 08:33:07 UTC Check cancelled
@github-actions
Copy link

github-actions bot commented Feb 14, 2025 •
edited
Loading

⚪ 2025-02-14 06:55:24 UTC Pre-commit check linux-x86_64-release-asan for a7a8833 has started.
⚪ 2025-02-14 06:55:34 UTC Artifacts will be uploaded here
⚪ 2025-02-14 06:58:40 UTC ya make is running...
🟡 2025-02-14 08:33:35 UTC ydbd size 3.6 GiB changed* by +615.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 02ee311 merge: a7a8833 diff diff %
ydbd size 3 883 750 960 Bytes 3 884 380 848 Bytes +615.1 KiB +0.016%
ydbd stripped size 1 359 918 928 Bytes 1 360 108 560 Bytes +185.2 KiB +0.014%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2025-02-14 08:33:37 UTC Check cancelled
@github-actions
Copy link

github-actions bot commented Feb 14, 2025 •
edited
Loading

⚪ 2025-02-14 08:37:21 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3604b45 has started.
⚪ 2025-02-14 08:37:33 UTC Artifacts will be uploaded here
⚪ 2025-02-14 08:40:35 UTC ya make is running...
🟡 2025-02-14 09:40:26 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27848 25244 0 6 2468 130

⚪ 2025-02-14 09:42:52 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-14 09:55:00 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
215 (only retried tests) 83 0 2 2 128

⚪ 2025-02-14 09:55:09 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-02-14 10:07:10 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
193 (only retried tests) 64 0 2 2 125

🟢 2025-02-14 10:07:19 UTC Build successful.
🟡 2025-02-14 10:07:41 UTC ydbd size 2.1 GiB changed* by +358.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 88b1d54 merge: 3604b45 diff diff %
ydbd size 2 233 189 520 Bytes 2 233 556 760 Bytes +358.6 KiB +0.016%
ydbd stripped size 473 938 616 Bytes 474 014 136 Bytes +73.8 KiB +0.016%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
@github-actions
Copy link

github-actions bot commented Feb 14, 2025 •
edited
Loading

⚪ 2025-02-14 08:38:21 UTC Pre-commit check linux-x86_64-release-asan for 3604b45 has started.
⚪ 2025-02-14 08:38:33 UTC Artifacts will be uploaded here
⚪ 2025-02-14 08:41:46 UTC ya make is running...
🟡 2025-02-14 09:53:47 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13671 13582 0 34 17 38

⚪ 2025-02-14 09:55:04 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-14 10:08:04 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
138 (only retried tests) 98 0 3 3 34

⚪ 2025-02-14 10:08:12 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-02-14 10:19:58 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
70 (only retried tests) 32 0 2 3 33

🟢 2025-02-14 10:20:06 UTC Build successful.
🟡 2025-02-14 10:20:37 UTC ydbd size 3.6 GiB changed* by +615.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 88b1d54 merge: 3604b45 diff diff %
ydbd size 3 883 750 960 Bytes 3 884 380 848 Bytes +615.1 KiB +0.016%
ydbd stripped size 1 359 918 928 Bytes 1 360 108 560 Bytes +185.2 KiB +0.014%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
@alexvru alexvru enabled auto-merge (squash) February 14, 2025 10:06
@github-actions
Copy link

github-actions bot commented Feb 14, 2025 •
edited
Loading

⚪ 2025-02-14 10:47:39 UTC Pre-commit check linux-x86_64-release-asan for 0f8f161 has started.
⚪ 2025-02-14 10:47:51 UTC Artifacts will be uploaded here
⚪ 2025-02-14 10:50:55 UTC ya make is running...
🟡 2025-02-14 12:01:31 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13671 13599 0 23 13 36

⚪ 2025-02-14 12:02:52 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-14 12:27:08 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
115 (only retried tests) 77 0 1 3 34

⚪ 2025-02-14 12:27:17 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-02-14 12:39:00 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
66 (only retried tests) 33 0 0 2 31

🟢 2025-02-14 12:39:07 UTC Build successful.
🟡 2025-02-14 12:39:38 UTC ydbd size 3.6 GiB changed* by +560.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: f97d523 merge: 0f8f161 diff diff %
ydbd size 3 884 094 912 Bytes 3 884 668 928 Bytes +560.6 KiB +0.015%
ydbd stripped size 1 360 024 400 Bytes 1 360 194 704 Bytes +166.3 KiB +0.013%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
@github-actions
Copy link

github-actions bot commented Feb 14, 2025 •
edited
Loading

⚪ 2025-02-14 10:47:42 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0f8f161 has started.
⚪ 2025-02-14 10:47:54 UTC Artifacts will be uploaded here
⚪ 2025-02-14 10:51:09 UTC ya make is running...
🟡 2025-02-14 12:13:34 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27848 25250 0 3 2461 134

⚪ 2025-02-14 12:16:19 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-14 12:30:33 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
209 (only retried tests) 82 0 0 1 126

🟢 2025-02-14 12:30:42 UTC Build successful.
🟡 2025-02-14 12:31:04 UTC ydbd size 2.1 GiB changed* by +320.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: f97d523 merge: 0f8f161 diff diff %
ydbd size 2 233 392 384 Bytes 2 233 720 224 Bytes +320.2 KiB +0.015%
ydbd stripped size 473 981 560 Bytes 474 044 408 Bytes +61.4 KiB +0.013%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
@alexvru alexvru merged commit 745a010 into ydb-platform:main Feb 14, 2025
12 checks passed
@alexvru alexvru deleted the vdisk/shred-impl branch February 14, 2025 12:59
This was referenced Feb 15, 2025
Merged
Merged
Merged
Closed
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 23, 2025
Merged
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 3, 2025
@alexvru
Finish implementing shred logic in VDisk (ydb-platform#14534)
9c74af1
blinkov pushed a commit that referenced this pull request Mar 21, 2025
@alexvru @blinkov
Finish implementing shred logic in VDisk (#14534)
7a31880
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

not-for-changelog

2 participants

@alexvru @kruall