Skip to content

Conversation

@MBkkt
Copy link
Contributor

@MBkkt MBkkt commented Feb 13, 2025

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

It adds additional layer for vector index: prefix impl table (prefix columns and id column)

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

Comment on lines +45 to +46
TString{NTableVectorKmeansTreeIndex::PostingTable} + NTableVectorKmeansTreeIndex::BuildSuffix0,
TString{NTableVectorKmeansTreeIndex::PostingTable} + NTableVectorKmeansTreeIndex::BuildSuffix1,
Copy link
Contributor Author

@MBkkt MBkkt Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really sure is it needed or not, but I found place where we check that index children table one of these, otherwise will be crash.
So it's my paranoia

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@MBkkt MBkkt marked this pull request as ready for review February 13, 2025 20:12
@MBkkt MBkkt requested review from a team as code owners February 13, 2025 20:12
@MBkkt MBkkt requested a review from CyberROFL February 13, 2025 20:13
@github-actions
Copy link

github-actions bot commented Feb 13, 2025

2025-02-13 20:15:36 UTC Pre-commit check linux-x86_64-release-asan for 63c48fa has started.
2025-02-13 20:16:09 UTC Artifacts will be uploaded here
2025-02-13 20:19:36 UTC ya make is running...
🟡 2025-02-13 21:43:36 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13636 13554 0 29 17 36

2025-02-13 21:44:45 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-13 21:56:57 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
127 (only retried tests) 91 0 0 3 33

🟢 2025-02-13 21:57:04 UTC Build successful.
🟢 2025-02-13 21:57:28 UTC ydbd size 3.6 GiB changed* by +86.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 28180f6 merge: 63c48fa diff diff %
ydbd size 3 882 848 808 Bytes 3 882 937 384 Bytes +86.5 KiB +0.002%
ydbd stripped size 1 359 665 552 Bytes 1 359 686 832 Bytes +20.8 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Feb 13, 2025

2025-02-13 20:16:32 UTC Pre-commit check linux-x86_64-relwithdebinfo for 63c48fa has started.
2025-02-13 20:16:35 UTC Artifacts will be uploaded here
2025-02-13 20:19:29 UTC ya make is running...
🟢 2025-02-13 21:27:07 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27811 25211 0 0 2469 131

🟢 2025-02-13 21:29:24 UTC Build successful.
🟢 2025-02-13 21:29:39 UTC ydbd size 2.1 GiB changed* by +64.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 28180f6 merge: 63c48fa diff diff %
ydbd size 2 232 662 400 Bytes 2 232 727 888 Bytes +64.0 KiB +0.003%
ydbd stripped size 473 850 552 Bytes 473 860 856 Bytes +10.1 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link
Member

@CyberROFL CyberROFL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

schemeshard - ok

@MBkkt MBkkt merged commit 8c57cab into ydb-platform:main Feb 14, 2025
13 checks passed
@MBkkt MBkkt self-assigned this Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants