Skip to content

YQ-4103 fixed overflow in kqp write actor CalculateNextAttemptDelay #14415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2025
Merged

YQ-4103 fixed overflow in kqp write actor CalculateNextAttemptDelay #14415

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ydb/core/kqp/runtime/kqp_write_actor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
namespace {
TDuration CalculateNextAttemptDelay(const NKikimr::NKqp::TWriteActorSettings& settings, ui64 attempt) {
auto delay = settings.StartRetryDelay;
for (ui64 index = 0; index < attempt; ++index) {
for (ui64 index = 0; index < attempt && delay * (1 - settings.UnsertaintyRatio) <= settings.MaxRetryDelay; ++index) {
delay *= settings.Multiplier;
}

Expand Down Expand Up @@ -214,7 +214,8 @@ class TKqpTableWriteActor : public TActorBootstrapped<TKqpTableWriteActor> {
const TActorId sessionActorId,
TIntrusivePtr<TKqpCounters> counters,
NWilson::TTraceId traceId)
: TypeEnv(typeEnv)
: MessageSettings(GetWriteActorSettings())
, TypeEnv(typeEnv)
, Alloc(alloc)
, MvccSnapshot(mvccSnapshot)
, LockMode(lockMode)
Expand Down
Loading