Skip to content

Increase MaxTableKeyColumns to 30 #14219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 6, 2025
Merged

Increase MaxTableKeyColumns to 30 #14219

merged 2 commits into from
Feb 6, 2025

Conversation

@azevaykin
Copy link
Collaborator

@azevaykin azevaykin commented Feb 5, 2025

Changelog entry

Maximum number of columns in a primary key has increased from 20 to 30.

Changelog category

  • Improvement

Additional information

...
@azevaykin azevaykin requested a review from a team as a code owner February 5, 2025 09:12
@azevaykin azevaykin requested review from ijon and snaury February 5, 2025 09:13
@github-actions
Copy link

github-actions bot commented Feb 5, 2025 •
edited
Loading

⚪ 2025-02-05 09:14:47 UTC Pre-commit check linux-x86_64-release-asan for 38f8b27 has started.
⚪ 2025-02-05 09:15:41 UTC Artifacts will be uploaded here
⚪ 2025-02-05 09:19:15 UTC ya make is running...
🟡 2025-02-05 10:31:26 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11677 11587 0 39 22 29

⚪ 2025-02-05 10:32:35 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-05 10:45:04 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
135 (only retried tests) 97 0 5 6 27

⚪ 2025-02-05 10:45:15 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-02-05 10:58:16 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
61 (only retried tests) 30 0 1 3 27

🟢 2025-02-05 10:58:23 UTC Build successful.
🟢 2025-02-05 10:58:55 UTC ydbd size 3.6 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 97e1be1 merge: 38f8b27 diff diff %
ydbd size 3 867 513 880 Bytes 3 867 513 784 Bytes -96 Bytes -0.000%
ydbd stripped size 1 355 274 864 Bytes 1 355 274 800 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
@github-actions
Copy link

github-actions bot commented Feb 5, 2025 •
edited
Loading

⚪ 2025-02-05 09:16:15 UTC Pre-commit check linux-x86_64-relwithdebinfo for 38f8b27 has started.
⚪ 2025-02-05 09:16:27 UTC Artifacts will be uploaded here
⚪ 2025-02-05 09:19:30 UTC ya make is running...
🟡 2025-02-05 10:17:28 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18945 17613 0 1 1201 130

⚪ 2025-02-05 10:19:16 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-05 10:31:25 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
200 (only retried tests) 76 0 1 0 123

⚪ 2025-02-05 10:31:33 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-02-05 10:42:39 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
181 (only retried tests) 60 0 1 0 120

🟢 2025-02-05 10:42:46 UTC Build successful.
🟢 2025-02-05 10:43:10 UTC ydbd size 2.1 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 97e1be1 merge: 38f8b27 diff diff %
ydbd size 2 224 124 904 Bytes 2 224 124 904 Bytes 0 Bytes 0.000%
ydbd stripped size 472 687 384 Bytes 472 687 384 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
snaury
snaury previously approved these changes Feb 5, 2025
View reviewed changes
CyberROFL
CyberROFL previously approved these changes Feb 5, 2025
View reviewed changes
@azevaykin azevaykin dismissed stale reviews from CyberROFL and snaury via 95c8005 February 5, 2025 15:42
@azevaykin azevaykin requested review from CyberROFL and snaury February 5, 2025 15:42
@github-actions
Copy link

github-actions bot commented Feb 5, 2025 •
edited
Loading

⚪ 2025-02-05 15:43:44 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4805471 has started.
⚪ 2025-02-05 15:43:56 UTC Artifacts will be uploaded here
⚪ 2025-02-05 15:46:53 UTC ya make is running...
🟡 2025-02-05 16:43:39 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18957 17466 0 6 1421 64

⚪ 2025-02-05 16:47:10 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-05 17:09:01 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
368 (only retried tests) 238 0 1 7 122

⚪ 2025-02-05 17:09:19 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-02-05 17:20:46 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
180 (only retried tests) 61 0 1 0 118

🟢 2025-02-05 17:20:56 UTC Build successful.
🟢 2025-02-05 17:21:20 UTC ydbd size 2.1 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 61b0e0a merge: 4805471 diff diff %
ydbd size 2 224 279 552 Bytes 2 224 279 552 Bytes 0 Bytes 0.000%
ydbd stripped size 472 693 016 Bytes 472 693 016 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
@github-actions
Copy link

github-actions bot commented Feb 5, 2025 •
edited
Loading

⚪ 2025-02-05 15:43:52 UTC Pre-commit check linux-x86_64-release-asan for 4805471 has started.
⚪ 2025-02-05 15:44:31 UTC Artifacts will be uploaded here
⚪ 2025-02-05 15:47:28 UTC ya make is running...
🟡 2025-02-05 17:12:36 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11687 11624 0 19 11 33

⚪ 2025-02-05 17:14:56 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-05 17:29:07 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
97 (only retried tests) 63 0 1 4 29

⚪ 2025-02-05 17:29:18 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-02-05 17:40:48 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
57 (only retried tests) 26 0 1 3 27

🟢 2025-02-05 17:40:55 UTC Build successful.
🟢 2025-02-05 17:41:25 UTC ydbd size 3.6 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 61b0e0a merge: 4805471 diff diff %
ydbd size 3 867 789 760 Bytes 3 867 789 664 Bytes -96 Bytes -0.000%
ydbd stripped size 1 355 299 824 Bytes 1 355 299 760 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
@azevaykin azevaykin enabled auto-merge (squash) February 5, 2025 16:25
@azevaykin azevaykin added the rebase-and-check Rebase PR with the current base branch and check label Feb 6, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Feb 6, 2025
@github-actions
Copy link

github-actions bot commented Feb 6, 2025 •
edited
Loading

⚪ 2025-02-06 06:21:03 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9a5b195 has started.
⚪ 2025-02-06 06:21:14 UTC Artifacts will be uploaded here
⚪ 2025-02-06 06:24:10 UTC ya make is running...
🟡 2025-02-06 07:16:35 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18957 17632 0 6 1191 128

⚪ 2025-02-06 07:18:15 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-06 07:37:33 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
199 (only retried tests) 77 0 1 0 121

⚪ 2025-02-06 07:37:41 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-02-06 07:47:51 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
180 (only retried tests) 61 0 0 0 119

🟢 2025-02-06 07:47:57 UTC Build successful.
🟢 2025-02-06 07:48:21 UTC ydbd size 2.1 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: e65db32 merge: 9a5b195 diff diff %
ydbd size 2 224 288 480 Bytes 2 224 288 480 Bytes 0 Bytes 0.000%
ydbd stripped size 472 697 048 Bytes 472 697 048 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
@github-actions
Copy link

github-actions bot commented Feb 6, 2025 •
edited
Loading

⚪ 2025-02-06 06:21:08 UTC Pre-commit check linux-x86_64-release-asan for 9a5b195 has started.
⚪ 2025-02-06 06:21:19 UTC Artifacts will be uploaded here
⚪ 2025-02-06 06:24:20 UTC ya make is running...
🟡 2025-02-06 07:38:16 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11687 11624 0 17 15 31

⚪ 2025-02-06 07:39:16 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-06 07:51:16 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
92 (only retried tests) 60 0 0 3 29

🟢 2025-02-06 07:51:25 UTC Build successful.
🟢 2025-02-06 07:51:52 UTC ydbd size 3.6 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: e65db32 merge: 9a5b195 diff diff %
ydbd size 3 867 839 024 Bytes 3 867 838 928 Bytes -96 Bytes -0.000%
ydbd stripped size 1 355 334 256 Bytes 1 355 334 192 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
@azevaykin azevaykin merged commit 0a3ca27 into ydb-platform:main Feb 6, 2025
17 of 18 checks passed
This was referenced Feb 6, 2025
Merged
Merged
@azevaykin azevaykin deleted the MaxTableKeyColumns branch February 11, 2025 10:07
lberserq pushed a commit to lberserq/ydb that referenced this pull request Feb 14, 2025
@azevaykin
Increase MaxTableKeyColumns to 30 (ydb-platform#14219)
07d5558
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement

3 participants

@azevaykin @snaury @CyberROFL