Kill tablet on BS failures #13766
Kill tablet on BS failures #13766
Conversation
| ⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| ⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| if (auto gc_ev = GCTask->BuildRequest(TBlobAddress(ev->Cookie, ev->Get()->Channel))) { | ||
| SendToBSProxy(NActors::TActivationContext::AsActorContext(), ev->Cookie, gc_ev.release(), ev->Cookie); | ||
| } else { | ||
| Send(TabletActorId, new TEvents::TEvPoison); |
There was a problem hiding this comment.
нужно добавить логику ожидания всех ответов от групп, которым отослали данные и только после этого убивать таблетку
также, нужно завершить, как-то, актор, в котором мы работаем
There was a problem hiding this comment.
Добавил нужную логику
| ⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| ⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| ⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| ⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| ⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| ⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| if (GCTask->HasFailures()) { | ||
| Send(TabletActorId, new TEvents::TEvPoison); | ||
| } else { | ||
| TActorContext::AsActorContext().Send(TabletActorId, std::make_unique<NColumnShard::TEvPrivate::TEvGarbageCollectionFinished>(GCTask)); |
There was a problem hiding this comment.
Почему вызовы Send разные?
| | ||
| void TGarbageCollectionActor::Handle(TEvBlobStorage::TEvCollectGarbageResult::TPtr& ev) { | ||
| NYDBTest::TControllers::GetColumnShardController()->OnCollectGarbageResult(ev); | ||
| ACFL_DEBUG("actor", "TEvCollectGarbageResult"); |
There was a problem hiding this comment.
Я бы почти всю логику отсюда перенёс в TGCTask::OnGcResult и возвращал оттуда enum типа {Fail, Retry, Continue}, но необязательно делать именно так.
3 participants
Changelog entry
Kill tablet on BS failures instead of aborting node process.
Changelog category
Additional information
This resolves #7901