Skip to content

Conversation

@molotkov-and
Copy link
Collaborator

@molotkov-and molotkov-and commented Nov 25, 2024

Changelog entry

Added the ability to check users' passwords whenever they are set with CREATE USER and ALTER USER
Were added following checks:

  • Minimum password length
  • Passwords must include a lowercase character
  • Passwords must include an uppercase character
  • Passwords must include a number
  • Passwords must include a special character from list !@#$%^&*()_+{}|<>?=
    All checks can be enabled or disabled over configuration

Changelog category

  • New feature

Additional information

...

@github-actions
Copy link

github-actions bot commented Nov 25, 2024

2024-11-25 16:20:53 UTC Pre-commit check linux-x86_64-release-asan for 6dba501 has started.
2024-11-25 16:21:03 UTC Artifacts will be uploaded here
2024-11-25 16:24:19 UTC ya make is running...
2024-11-25 16:27:49 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Nov 25, 2024

2024-11-25 16:21:08 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6dba501 has started.
2024-11-25 16:21:19 UTC Artifacts will be uploaded here
2024-11-25 16:24:53 UTC ya make is running...
2024-11-25 16:27:47 UTC Check cancelled

void ChangeDiskSpaceSoftQuotaBytes(i64 delta) override;
void AddDiskSpaceSoftQuotaBytes(EUserFacingStorageType storageType, ui64 addend) override;

NLogin::TPasswordCheckParameters PasswordCheckParameters;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this is unnecessary and it make extra copying

@github-actions
Copy link

github-actions bot commented Nov 25, 2024

2024-11-25 16:31:45 UTC Pre-commit check linux-x86_64-release-asan for 79e0fb7 has started.
2024-11-25 16:31:56 UTC Artifacts will be uploaded here
2024-11-25 16:35:10 UTC ya make is running...
🟡 2024-11-25 18:12:14 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10730 10662 0 14 8 46

🟢 2024-11-25 18:13:06 UTC Build successful.
🟡 2024-11-25 18:13:34 UTC ydbd size 4.9 GiB changed* by +218.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 2bc34d4 merge: 79e0fb7 diff diff %
ydbd size 5 285 275 800 Bytes 5 285 499 824 Bytes +218.8 KiB +0.004%
ydbd stripped size 1 360 239 152 Bytes 1 360 302 160 Bytes +61.5 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 25, 2024

2024-11-25 16:32:05 UTC Pre-commit check linux-x86_64-relwithdebinfo for 79e0fb7 has started.
2024-11-25 16:32:16 UTC Artifacts will be uploaded here
2024-11-25 16:35:48 UTC ya make is running...
🟡 2024-11-25 18:06:46 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
26533 23698 0 1 2720 114

2024-11-25 18:08:58 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-25 18:20:53 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
116 (only retried tests) 7 0 0 0 109

🟢 2024-11-25 18:21:00 UTC Build successful.
🟡 2024-11-25 18:21:19 UTC ydbd size 2.5 GiB changed* by +106.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 2bc34d4 merge: 79e0fb7 diff diff %
ydbd size 2 690 447 960 Bytes 2 690 556 752 Bytes +106.2 KiB +0.004%
ydbd stripped size 482 237 072 Bytes 482 257 904 Bytes +20.3 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@molotkov-and molotkov-and linked an issue Nov 25, 2024 that may be closed by this pull request
@molotkov-and molotkov-and force-pushed the fstec/password-prerequisites branch from e09c6e1 to 920688b Compare November 27, 2024 09:25
@molotkov-and molotkov-and marked this pull request as draft November 27, 2024 09:25
@github-actions
Copy link

github-actions bot commented Nov 27, 2024

2024-11-27 09:29:27 UTC Pre-commit check linux-x86_64-relwithdebinfo for f0c3e15 has started.
2024-11-27 09:29:40 UTC Artifacts will be uploaded here
2024-11-27 09:33:08 UTC ya make is running...
🔴 2024-11-27 09:36:06 UTC Build failed, see the logs. Also see fail summary

@github-actions
Copy link

github-actions bot commented Nov 27, 2024

2024-11-27 09:29:33 UTC Pre-commit check linux-x86_64-release-asan for f0c3e15 has started.
2024-11-27 09:29:45 UTC Artifacts will be uploaded here
2024-11-27 09:33:17 UTC ya make is running...
🔴 2024-11-27 09:36:51 UTC Build failed, see the logs. Also see fail summary

@molotkov-and molotkov-and force-pushed the fstec/password-prerequisites branch from 920688b to c539ab7 Compare November 27, 2024 16:34
@github-actions
Copy link

github-actions bot commented Nov 27, 2024

2024-11-27 16:35:54 UTC Pre-commit check linux-x86_64-release-asan for 4cdc3a9 has started.
2024-11-27 16:36:05 UTC Artifacts will be uploaded here
2024-11-27 16:39:20 UTC ya make is running...
🟡 2024-11-27 18:10:21 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15453 15386 0 11 5 51

🟢 2024-11-27 18:11:35 UTC Build successful.
🟡 2024-11-27 18:12:09 UTC ydbd size 4.9 GiB changed* by +207.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: c381728 merge: 4cdc3a9 diff diff %
ydbd size 5 294 418 648 Bytes 5 294 630 848 Bytes +207.2 KiB +0.004%
ydbd stripped size 1 361 080 464 Bytes 1 361 141 072 Bytes +59.2 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 27, 2024

2024-11-27 16:35:56 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4cdc3a9 has started.
2024-11-27 16:36:06 UTC Artifacts will be uploaded here
2024-11-27 16:39:23 UTC ya make is running...
🟡 2024-11-27 18:05:28 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
32881 30046 0 5 2719 111

2024-11-27 18:08:09 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-27 18:19:47 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
794 (only retried tests) 686 0 0 0 108

🟢 2024-11-27 18:19:59 UTC Build successful.
🟡 2024-11-27 18:20:17 UTC ydbd size 2.5 GiB changed* by +103.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: c381728 merge: 4cdc3a9 diff diff %
ydbd size 2 694 781 912 Bytes 2 694 888 104 Bytes +103.7 KiB +0.004%
ydbd stripped size 482 174 288 Bytes 482 194 064 Bytes +19.3 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@molotkov-and molotkov-and force-pushed the fstec/password-prerequisites branch from c539ab7 to 4875722 Compare November 28, 2024 11:31
@molotkov-and molotkov-and force-pushed the fstec/password-prerequisites branch from 4875722 to f9f1267 Compare November 28, 2024 12:30
@molotkov-and molotkov-and marked this pull request as ready for review November 28, 2024 12:31
@github-actions
Copy link

github-actions bot commented Nov 28, 2024

2024-11-28 12:32:35 UTC Pre-commit check linux-x86_64-release-asan for 4648110 has started.
2024-11-28 12:32:47 UTC Artifacts will be uploaded here
2024-11-28 12:36:02 UTC ya make is running...
🟡 2024-11-28 14:08:59 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15460 15383 0 19 7 51

🟢 2024-11-28 14:10:14 UTC Build successful.
🟢 2024-11-28 14:10:41 UTC ydbd size 4.9 GiB changed* by -13.4 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: a02f6d5 merge: 4648110 diff diff %
ydbd size 5 294 884 792 Bytes 5 280 836 400 Bytes -13.4 MiB -0.265%
ydbd stripped size 1 361 164 464 Bytes 1 361 256 144 Bytes +89.5 KiB +0.007%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 28, 2024

2024-11-28 12:34:38 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4648110 has started.
2024-11-28 12:34:48 UTC Artifacts will be uploaded here
2024-11-28 12:38:02 UTC ya make is running...
🟡 2024-11-28 14:03:15 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
32888 30051 0 5 2719 113

2024-11-28 14:05:57 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-28 14:17:30 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
813 (only retried tests) 705 0 0 0 108

🟢 2024-11-28 14:17:42 UTC Build successful.
🟡 2024-11-28 14:18:05 UTC ydbd size 2.5 GiB changed* by +114.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 97c9f43 merge: 4648110 diff diff %
ydbd size 2 686 355 384 Bytes 2 686 472 272 Bytes +114.1 KiB +0.004%
ydbd stripped size 482 203 696 Bytes 482 221 328 Bytes +17.2 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Enjection
Enjection previously approved these changes Nov 28, 2024
Co-authored-by: azevaykin <145343289+azevaykin@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Nov 28, 2024

2024-11-28 14:59:38 UTC Pre-commit check linux-x86_64-release-asan for de9551b has started.
2024-11-28 14:59:48 UTC Artifacts will be uploaded here
2024-11-28 15:03:01 UTC ya make is running...
2024-11-28 15:47:17 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Nov 28, 2024

2024-11-28 15:00:51 UTC Pre-commit check linux-x86_64-relwithdebinfo for de9551b has started.
2024-11-28 15:00:55 UTC Artifacts will be uploaded here
2024-11-28 15:04:11 UTC ya make is running...
2024-11-28 15:47:06 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Nov 28, 2024

2024-11-28 15:50:51 UTC Pre-commit check linux-x86_64-release-asan for 8fb11fb has started.
2024-11-28 15:51:40 UTC Artifacts will be uploaded here
2024-11-28 15:55:25 UTC ya make is running...
🟡 2024-11-28 16:59:03 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15469 15397 0 12 10 50

🟢 2024-11-28 17:00:23 UTC Build successful.
🟡 2024-11-28 17:00:51 UTC ydbd size 4.9 GiB changed* by +235.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 2f89980 merge: 8fb11fb diff diff %
ydbd size 5 281 015 488 Bytes 5 281 256 968 Bytes +235.8 KiB +0.005%
ydbd stripped size 1 361 303 664 Bytes 1 361 372 432 Bytes +67.2 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 28, 2024

2024-11-28 15:51:06 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8fb11fb has started.
2024-11-28 15:51:55 UTC Artifacts will be uploaded here
2024-11-28 15:55:50 UTC ya make is running...
🟡 2024-11-28 16:55:37 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
32898 30056 0 3 2725 114

2024-11-28 16:58:21 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-28 17:10:32 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
728 (only retried tests) 620 0 0 0 108

🟢 2024-11-28 17:10:41 UTC Build successful.
🟡 2024-11-28 17:11:00 UTC ydbd size 2.5 GiB changed* by +114.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 2f89980 merge: 8fb11fb diff diff %
ydbd size 2 686 661 376 Bytes 2 686 778 208 Bytes +114.1 KiB +0.004%
ydbd stripped size 482 255 888 Bytes 482 273 456 Bytes +17.2 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Dec 5, 2024

2024-12-05 10:07:23 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6a62b96 has started.
2024-12-05 10:07:53 UTC Artifacts will be uploaded here
2024-12-05 10:11:48 UTC ya make is running...
🟡 2024-12-05 11:47:13 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
32918 30086 0 1 2719 112

2024-12-05 11:49:56 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-05 12:01:31 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
729 (only retried tests) 622 0 0 0 107

🟢 2024-12-05 12:01:40 UTC Build successful.
🟡 2024-12-05 12:02:01 UTC ydbd size 2.5 GiB changed* by +121.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: ffa5093 merge: 6a62b96 diff diff %
ydbd size 2 699 922 216 Bytes 2 700 046 480 Bytes +121.4 KiB +0.005%
ydbd stripped size 483 579 248 Bytes 483 604 912 Bytes +25.1 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Dec 5, 2024

2024-12-05 10:10:28 UTC Pre-commit check linux-x86_64-release-asan for 6a62b96 has started.
2024-12-05 10:10:40 UTC Artifacts will be uploaded here
2024-12-05 10:13:54 UTC ya make is running...
🟡 2024-12-05 11:45:23 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15463 15391 0 19 7 46

🟢 2024-12-05 11:46:38 UTC Build successful.
🟡 2024-12-05 11:47:09 UTC ydbd size 4.9 GiB changed* by +233.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: ffa5093 merge: 6a62b96 diff diff %
ydbd size 5 304 181 048 Bytes 5 304 419 768 Bytes +233.1 KiB +0.005%
ydbd stripped size 1 365 337 968 Bytes 1 365 402 352 Bytes +62.9 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Dec 6, 2024

2024-12-06 12:50:23 UTC Pre-commit check linux-x86_64-relwithdebinfo for 2110ea3 has started.
2024-12-06 12:50:35 UTC Artifacts will be uploaded here
2024-12-06 12:53:59 UTC ya make is running...
2024-12-06 13:29:35 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Dec 6, 2024

2024-12-06 12:50:30 UTC Pre-commit check linux-x86_64-release-asan for 2110ea3 has started.
2024-12-06 12:50:41 UTC Artifacts will be uploaded here
2024-12-06 12:53:56 UTC ya make is running...
2024-12-06 13:29:38 UTC Check cancelled

@molotkov-and molotkov-and force-pushed the fstec/password-prerequisites branch from 4d840ff to bc0160f Compare December 6, 2024 13:29
@github-actions
Copy link

github-actions bot commented Dec 6, 2024

2024-12-06 13:31:05 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5baa04a has started.
2024-12-06 13:31:27 UTC Artifacts will be uploaded here
2024-12-06 13:34:56 UTC ya make is running...
🟡 2024-12-06 14:38:11 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
32943 30105 0 1 2721 116

2024-12-06 14:40:51 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-06 14:53:41 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
784 (only retried tests) 675 0 0 0 109

🟢 2024-12-06 14:53:50 UTC Build successful.
🟡 2024-12-06 14:54:11 UTC ydbd size 2.5 GiB changed* by +124.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 17066f1 merge: 5baa04a diff diff %
ydbd size 2 699 201 576 Bytes 2 699 329 480 Bytes +124.9 KiB +0.005%
ydbd stripped size 483 500 720 Bytes 483 530 480 Bytes +29.1 KiB +0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Dec 6, 2024

2024-12-06 13:33:40 UTC Pre-commit check linux-x86_64-release-asan for 5baa04a has started.
2024-12-06 13:33:52 UTC Artifacts will be uploaded here
2024-12-06 13:37:18 UTC ya make is running...
🟡 2024-12-06 14:47:15 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15484 15406 0 25 8 45

🟢 2024-12-06 14:48:33 UTC Build successful.
🟡 2024-12-06 14:49:04 UTC ydbd size 4.9 GiB changed* by +236.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 17066f1 merge: 5baa04a diff diff %
ydbd size 5 305 570 352 Bytes 5 305 812 632 Bytes +236.6 KiB +0.005%
ydbd stripped size 1 365 574 736 Bytes 1 365 643 184 Bytes +66.8 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@molotkov-and molotkov-and merged commit e838a62 into ydb-platform:main Dec 11, 2024
10 checks passed
@molotkov-and molotkov-and deleted the fstec/password-prerequisites branch December 11, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

4 participants