Skip to content

optimize initializiton of allocation units #10969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Nov 8, 2024
Merged

optimize initializiton of allocation units #10969

merged 10 commits into from
Nov 8, 2024

Conversation

@vporyadke
Copy link
Collaborator

@vporyadke vporyadke commented Oct 28, 2024 •
edited by CyberROFL
Loading

Changelog entry

Optimized Hive startup time.

Changelog category

  • Performance improvement

Additional information

...
@github-actions
Copy link

github-actions bot commented Oct 28, 2024 •
edited
Loading

⚪ 2024-10-28 07:12:16 UTC Pre-commit check linux-x86_64-release-asan for b5dbe5e has started.
⚪ 2024-10-28 07:12:27 UTC Artifacts will be uploaded here
🔴 2024-10-28 07:14:24 UTC Graph compare failed, see the logs.
@github-actions
Copy link

github-actions bot commented Oct 28, 2024 •
edited
Loading

⚪ 2024-10-28 07:13:54 UTC Pre-commit check linux-x86_64-relwithdebinfo for b5dbe5e has started.
⚪ 2024-10-28 07:14:04 UTC Artifacts will be uploaded here
🔴 2024-10-28 07:16:01 UTC Graph compare failed, see the logs.
@github-actions
Copy link

github-actions bot commented Oct 28, 2024 •
edited
Loading

⚪ 2024-10-28 08:36:50 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9f64641 has started.
⚪ 2024-10-28 08:37:02 UTC Artifacts will be uploaded here
⚪ 2024-10-28 08:40:01 UTC ya make is running...
🟡 2024-10-28 09:27:21 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15275 13781 0 3 1394 97

⚪ 2024-10-28 09:28:36 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-28 09:35:53 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
98 (only retried tests) 8 0 0 0 90

🟢 2024-10-28 09:36:00 UTC Build successful.
🟡 2024-10-28 09:36:18 UTC ydbd size 2.8 GiB changed* by +128.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 4a9f860 merge: 9f64641 diff diff %
ydbd size 3 033 099 368 Bytes 3 033 231 336 Bytes +128.9 KiB +0.004%
ydbd stripped size 480 544 472 Bytes 480 558 040 Bytes +13.2 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
@github-actions
Copy link

github-actions bot commented Oct 28, 2024 •
edited
Loading

⚪ 2024-10-28 08:36:59 UTC Pre-commit check linux-x86_64-release-asan for 9f64641 has started.
⚪ 2024-10-28 08:37:10 UTC Artifacts will be uploaded here
⚪ 2024-10-28 08:40:08 UTC ya make is running...
🟡 2024-10-28 10:07:14 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10153 9862 0 130 61 100

🟢 2024-10-28 10:08:09 UTC Build successful.
🟡 2024-10-28 10:08:43 UTC ydbd size 5.7 GiB changed* by +208.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 4a9f860 merge: 9f64641 diff diff %
ydbd size 6 138 348 688 Bytes 6 138 562 608 Bytes +208.9 KiB +0.003%
ydbd stripped size 1 531 765 808 Bytes 1 531 792 304 Bytes +25.9 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
@vporyadke vporyadke requested a review from ijon October 28, 2024 09:02
ijon
ijon previously approved these changes Oct 29, 2024
View reviewed changes
ydb/core/mind/hive/tx__load_everything.cpp
auto ownerId = owners.GetValue<Schema::TabletOwners::OwnerId>();

Self->Keeper.AddOwnedSequence(ownerId, {begin, end});
Self->Keeper.AddOwnedSequence(ownerId, {begin, end});
Copy link
Collaborator

@ijon ijon Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Пробел вставлен лишний
@github-actions
Copy link

github-actions bot commented Nov 6, 2024 •
edited
Loading

⚪ 2024-11-06 08:23:11 UTC Pre-commit check linux-x86_64-release-asan for 330ca70 has started.
⚪ 2024-11-06 08:23:22 UTC Artifacts will be uploaded here
⚪ 2024-11-06 08:26:34 UTC ya make is running...
🟡 2024-11-06 09:37:31 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9258 9179 0 35 14 30

🟢 2024-11-06 09:38:27 UTC Build successful.
🟡 2024-11-06 09:39:01 UTC ydbd size 5.7 GiB changed* by +205.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: cea219c merge: 330ca70 diff diff %
ydbd size 6 153 093 296 Bytes 6 153 303 416 Bytes +205.2 KiB +0.003%
ydbd stripped size 1 535 476 944 Bytes 1 535 504 080 Bytes +26.5 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
@github-actions
Copy link

github-actions bot commented Nov 6, 2024 •
edited
Loading

⚪ 2024-11-06 08:23:15 UTC Pre-commit check linux-x86_64-relwithdebinfo for 330ca70 has started.
⚪ 2024-11-06 08:23:26 UTC Artifacts will be uploaded here
⚪ 2024-11-06 08:26:33 UTC ya make is running...
🟡 2024-11-06 09:14:12 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15327 13802 0 12 1415 98

⚪ 2024-11-06 09:15:36 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-11-06 09:30:22 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
119 (only retried tests) 25 0 1 0 93

⚪ 2024-11-06 09:30:30 UTC ya make is running... (failed tests rerun, try 3)
🟢 2024-11-06 09:42:03 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
94 (only retried tests) 1 0 0 0 93

🟢 2024-11-06 09:42:11 UTC Build successful.
🟡 2024-11-06 09:42:34 UTC ydbd size 2.8 GiB changed* by +123.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: cea219c merge: 330ca70 diff diff %
ydbd size 3 040 726 456 Bytes 3 040 852 640 Bytes +123.2 KiB +0.004%
ydbd stripped size 481 703 736 Bytes 481 713 272 Bytes +9.3 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
@vporyadke vporyadke merged commit dc2fcaf into ydb-platform:main Nov 8, 2024
10 checks passed
@niksaveliev niksaveliev mentioned this pull request Nov 8, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Nov 10, 2024
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Nov 11, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Nov 13, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Nov 14, 2024
Merged
@github-actions
Copy link

github-actions bot commented Apr 16, 2025

🟢 2025-04-16 10:43:13 UTC The validation of the Pull Request description is successful.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance

2 participants

@vporyadke @ijon